Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ [RUM-253] add E2E tests related to compression #2416

Merged
merged 3 commits into from
Oct 31, 2023
Merged

✅ [RUM-253] add E2E tests related to compression #2416

merged 3 commits into from
Oct 31, 2023

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Add E2E tests related to RUM data compression

Changes

  • Light refactoring
  • Add E2E tests related to RUM data compression

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer
Copy link
Member Author

BenoitZugmeyer commented Sep 5, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was autogenerated by Freephite.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 5, 2023 10:47
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Sep 5, 2023

🚂 Branch Integration: starting soon, merge in < 0s

commit 64156e4817 will soon be integrated into staging-36.

This build is going to start soon! (estimated merge in less than 0s)

you can cancel this operation by commenting your pull request with /to-staging -c!

This was referenced Sep 5, 2023
Merged
Merged
Merged
@dd-devflow
Copy link

dd-devflow bot commented Sep 5, 2023

🚂 Branch Integration: this commit was successfully integrated

Commit 64156e4817 has been merged into staging-36 in merge commit bd2ac015c5.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-36 label Sep 5, 2023
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--add-e2e-test branch 4 times, most recently from abcfe79 to beab420 Compare September 5, 2023 16:53
bcaudan
bcaudan reviewed Sep 7, 2023
View reviewed changes
test/e2e/scenario/transport.scenario.ts
Comment on lines +30 to +33
// Ignore this test on Safari desktop and Firefox because the Worker actually works even with
// CSP restriction.
// TODO: Remove this condition when upgrading to Safari 15 and Firefox 99
if (!((getBrowserName() === 'safari' && getPlatformName() === 'macos') || getBrowserName() === 'firefox')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 thought: ‏did you consider bumping them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did, but I decided that it was not the right place to do it, as it might involve more things (everywhere we use getBrowserName for skipping tests, we should see if it still makes sense with newer versions)

@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--rum-data branch 3 times, most recently from 8329f48 to 399820b Compare September 8, 2023 17:12
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 8, 2023 17:12
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--add-e2e-test branch from beab420 to 7ffcfbd Compare September 8, 2023 17:14
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--rum-data branch from 399820b to 3a7384d Compare September 11, 2023 14:12
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--add-e2e-test branch from 7ffcfbd to 966e895 Compare September 11, 2023 14:12
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--rum-data branch from e4853e1 to ebb9a24 Compare October 30, 2023 13:48
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--add-e2e-test branch from 966e895 to c06bea7 Compare October 30, 2023 13:49
Base automatically changed from benoit/compress--rum-data to main October 31, 2023 09:06
@BenoitZugmeyer BenoitZugmeyer force-pushed the benoit/compress--add-e2e-test branch from c06bea7 to 735e91c Compare October 31, 2023 09:07
@BenoitZugmeyer BenoitZugmeyer merged commit 0c81b8e into main Oct 31, 2023
2 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/compress--add-e2e-test branch October 31, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amortemousque amortemousque amortemousque approved these changes

@bcaudan bcaudan bcaudan approved these changes

Assignees
No one assigned
Labels
staging-36
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenoitZugmeyer @bcaudan @amortemousque