Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-1062] add a prefix to all console message displayed by the SDK #2432

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Sep 19, 2023

Motivation

Mentioning that the message come from the Datadog Browser SDK could help users figure out what's wrong, especially when they are using multiple RUM SDKs at the same time.

See #2414 (comment)

Changes

Add a Datadog Browser SDK: prefix to all messages displayed by the SDK.

Testing

  • Local
  • Staging
  • Unit -- no unit test as it's not easy to test: we would need to mock the console before binding its methods, but binding those methods during module evaluation is by design: we want to make sure we keep a reference to them before any instrumentation occurs.
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners September 19, 2023 16:49
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Sep 19, 2023

🚂 Branch Integration: starting soon, merge in < 0s

commit e69125a546 will soon be integrated into staging-38.

This build is going to start soon! (estimated merge in less than 0s)

you can cancel this operation by commenting your pull request with /to-staging -c!

@dd-devflow
Copy link

dd-devflow bot commented Sep 19, 2023

🚂 Branch Integration: this commit was successfully integrated

Commit e69125a546 has been merged into staging-38 in merge commit 293abff52f.

Check out the triggered pipeline on Gitlab 🦊

@BenoitZugmeyer BenoitZugmeyer merged commit 5b6bb0b into main Sep 20, 2023
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/prefix-display-message branch September 20, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants