Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUMF-1178] improve logs assembly part 2 #1463

Merged
merged 8 commits into from
Apr 6, 2022

Conversation

amortemousque
Copy link
Collaborator

@amortemousque amortemousque commented Mar 28, 2022

Motivation

Follow up of #1425
The main goal of the PR is to seperate console, report and raw error collection from the startLogs module.
I created a collection for each of them a bit like what we have in the RUM side.

Changes

  • Create a raw error collection for network and runtime error
  • Create a console collection
  • Create a report collection
  • Move assemble tests out of startLog spec

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner March 28, 2022 14:01
@amortemousque amortemousque force-pushed the aymeric/improve-logs-assembly-part-2 branch from ed17e5f to ab0a69e Compare March 28, 2022 14:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #1463 (9b98fb6) into main (63aac10) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   89.93%   89.88%   -0.05%     
==========================================
  Files         107      111       +4     
  Lines        4302     4312      +10     
  Branches      957      957              
==========================================
+ Hits         3869     3876       +7     
- Misses        433      436       +3     
Impacted Files Coverage Δ
packages/core/src/tools/error.ts 90.62% <ø> (ø)
packages/logs/src/boot/startLogs.ts 70.45% <100.00%> (-15.66%) ⬇️
packages/logs/src/domain/assemble.ts 100.00% <100.00%> (ø)
...domain/logsCollection/console/consoleCollection.ts 100.00% <100.00%> (ø)
...sCollection/networkError/networkErrorCollection.ts 92.04% <100.00%> (ø)
...c/domain/logsCollection/report/reportCollection.ts 100.00% <100.00%> (ø)
...sCollection/runtimeError/runtimeErrorCollection.ts 100.00% <100.00%> (ø)
packages/logs/src/domain/reportRawError.ts 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@amortemousque amortemousque changed the title ♻️ improve logs assembly part 2 ♻️ [RUMF-1178] improve logs assembly part 2 Mar 29, 2022
@amortemousque amortemousque force-pushed the aymeric/improve-logs-assembly-part-2 branch from 3cb86e7 to d064de3 Compare March 30, 2022 14:32
@amortemousque amortemousque force-pushed the aymeric/improve-logs-assembly-part-2 branch from d064de3 to c48a455 Compare March 30, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants