-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUMF-1178] improve logs assembly part 2 #1463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/improve-logs-assembly-part-2
branch
from
March 28, 2022 14:23
ed17e5f
to
ab0a69e
Compare
Codecov Report
@@ Coverage Diff @@
## main #1463 +/- ##
==========================================
- Coverage 89.93% 89.88% -0.05%
==========================================
Files 107 111 +4
Lines 4302 4312 +10
Branches 957 957
==========================================
+ Hits 3869 3876 +7
- Misses 433 436 +3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
amortemousque
changed the title
♻️ improve logs assembly part 2
♻️ [RUMF-1178] improve logs assembly part 2
Mar 29, 2022
packages/logs/src/domain/logsCollection/rawError/rawErrorCollection.ts
Outdated
Show resolved
Hide resolved
amortemousque
force-pushed
the
aymeric/improve-logs-assembly-part-2
branch
from
March 30, 2022 14:32
3cb86e7
to
d064de3
Compare
amortemousque
force-pushed
the
aymeric/improve-logs-assembly-part-2
branch
from
March 30, 2022 14:36
d064de3
to
c48a455
Compare
BenoitZugmeyer
approved these changes
Apr 4, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up of #1425
The main goal of the PR is to seperate console, report and raw error collection from the startLogs module.
I created a collection for each of them a bit like what we have in the RUM side.
Changes
Testing
I have gone over the contributing documentation.