🐛 [RUMF-1303] stop forwarding network errors when forwardErrorsToLogs is false #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amortemousque
force-pushed
the
aymeric/fix-network-error-forwardErrorsToLogs
branch
from
88f464f to
5b86e50
Compare
Codecov Report
@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
+ Coverage 90.74% 90.77% +0.03%
==========================================
Files 121 121
Lines 4538 4543 +5
Branches 1018 1018
==========================================
+ Hits 4118 4124 +6
+ Misses 420 419 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
amortemousque
commented
Jun 15, 2022
| source: ErrorSource.SOURCE, | ||
| startClocks: { relative: 1234 as RelativeTime, timeStamp: 123456789 as TimeStamp }, | ||
| type: 'Error', | ||
| it('should send runtime errors', (done) => { |
There was a problem hiding this comment.
I updated the test to really trigger a runtime error instead of using the observable, because I found it more secure.
With the previous implem of runtimeErrorCollection, when sending a message in rawErrorObservable the collection worked even if the forwardErrorsToLogs was false.
amortemousque
commented
Jun 15, 2022
| if (configuration.forwardErrorsToLogs) { | ||
| trackRuntimeError(rawErrorObservable) | ||
| export function startRuntimeErrorCollection(configuration: LogsConfiguration, lifeCycle: LifeCycle) { | ||
| if (!configuration.forwardErrorsToLogs) { |
There was a problem hiding this comment.
Avoid to unnecessary listen to the observable when forwardErrorsToLogs is false
packages/logs/src/domain/logsCollection/runtimeError/runtimeErrorCollection.ts
Outdated
Show resolved
Hide resolved
BenoitZugmeyer
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since Logs v4.7.1, the Logs SDK forward network errors even when forwardErrorsToLogs is false. This issue as been introduced by Logs assembly refactoring PR #1463.
This PR fix it.
Changes
Check forwardErrorsToLogs in networkErrorCollection.ts
Testing
I have gone over the contributing documentation.