Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending Network errors, when the flag forwardErrorsToLogs is false. #1590

Closed
ntishkevich opened this issue Jun 13, 2022 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@ntishkevich
Copy link

ntishkevich commented Jun 13, 2022

Hi guys.

I've noticed that amount of network errors has been increased significantly after upgrading @datadog/browser-logs to 4.9.0 from 3.7.0. I've checked the init configuration to be sure, that I've disabled forwarding all errors to DataDog using the flag forwardErrorsToLogs with false value. And this flag actually has false value, but network errors are still sent to DataDog and I'm able to see them in Log Explorer.

So I've checked the source code of sdk and this flag is used only for collecting runtime errors, but it isn't used for network errors and the usage were removed in the PR #1463 (but it is still disable gathering network errors in the version 4.7.0 .
So I'm curious does this flag still disable gathering network errors anymore? Thanks.

@amortemousque
Copy link
Collaborator

amortemousque commented Jun 14, 2022

Hello @ntishkevich,
Thanks for your feedback. forwardErrorsToLogs should still disable/enable network error tracking. Like you said, the issue as been introduce by the PR #1463. I'll look into it and let you know when a fix is available.

@amortemousque amortemousque added the bug Something isn't working label Jun 14, 2022
@amortemousque
Copy link
Collaborator

Hi @ntishkevich ,
The fix is available in @datadog/browser-logs version 4.11.5.

@ntishkevich
Copy link
Author

ntishkevich commented Jun 16, 2022

Hi @ntishkevich ,
The fix is available in @datadog/browser-logs version 4.11.5.

Hi, @amortemousque. It sounds great! Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants