This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Staging --> master (v2.1.9) #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new navs to site
Increased contrast of map greens
Brings link/button blue into 508 compliance over $pale-gray
Official Website banner: simplified / Global header changes
Megachart negatives numbers
Fix position of oil rig on homepage
migrate to federalist.fr.cloud.gov
Other revenue megachart
2016 Federal revenue by company
Darkened county fills on case-study — and state laws — maps
* Various table format adjustments - Equalized top and bottom cell padding - Changed indenting method to padding-left - Added styling for the “sup” class, which enabled me to shift the superscript numbers slightly down, as well as adding a little spacing on the left (so they don’t almost hit the adjacent text) - Tightened up the table line height a bit On these tables, we still need to adjust the leading for lines which have footnotes. (The number forces line heights to be too generous.) Definitely high likelihood of syntax glitches here! :fingers crossed: More to come! * fixed footnote markdown bug * az
* added new search fields * coerce url * coerce url * coerce
Brought this table into line with others, style wise, and eliminated the ` article_table-gray ` class, which is now used nowhere. **Note: I couldn’t find what’s causing the gray fill on the table header. Help!**
We may now be mergeable! 🙏
Tables schmables
Address broken internal links
Dev --> staging
houndci-bot
reviewed
Apr 18, 2017
| @include respond-to(medium-up) { | ||
| @include span-columns(3); | ||
| } | ||
| @include respond-to(medium-up) { |
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 3 spaces
| @@ -48,11 +47,13 @@ header, | |||
| } | |||
|
|
|||
| .header-left { | |||
| @include span-columns(6); | |||
| @include span-columns(6); | |||
| margin-bottom: $base-padding; | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 3 spaces
| @@ -48,11 +47,13 @@ header, | |||
| } | |||
|
|
|||
| .header-left { | |||
| @include span-columns(6); | |||
| @include span-columns(6); | |||
There was a problem hiding this comment.
Line should be indented 2 spaces, but was indented 3 spaces
| @@ -12,15 +12,16 @@ def create_store(collections) | |||
| obj = {} | |||
| collections.each do |collection| | |||
| collection['docs'].each do |doc| | |||
| if doc.data['title'] && doc.data['description'] && doc.data['tag'] && doc.data['permalink'] | |||
| url = doc.data['permalink'] || doc.url | |||
| if doc.data['title'] && doc.data['description'] && doc.data['tag'] && url | |||
There was a problem hiding this comment.
Use a guard clause instead of wrapping the code inside a conditional expression.
| @@ -74,6 +77,28 @@ def intcomma(value, delimiter=",") | |||
| orig == copy ? copy : intcomma(copy, delimiter) | |||
| end | |||
|
|
|||
| def intcomma_dollar(value, delimiter=",") | |||
There was a problem hiding this comment.
Surrounding space missing in default value assignment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
| @@ -5,7 +5,7 @@ def generate(site) | |||
| # Federalist preview URL for this branch. | |||
| branch = ENV['BRANCH'] | |||
| if branch && branch != 'master' | |||
| site.config['url'] = "https://federalist.18f.gov/preview/18F/doi-extractives-data/#{branch}" | |||
| site.config['url'] = "https://federalist.fr.cloud.gov/preview/18f/doi-extractives-data/#{branch}" | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😎 PREVIEW
Changes proposed in this pull request:
/cc @gemfarmer @ericronne