Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Tables schmables #2246

Merged
merged 4 commits into from
Apr 17, 2017
Merged

Tables schmables #2246

merged 4 commits into from
Apr 17, 2017

Conversation

gemfarmer
Copy link
Contributor

@gemfarmer gemfarmer commented Apr 5, 2017 •
edited by ericronne
Loading

@gemfarmer gemfarmer changed the title Tables schmables [WIP] Tables schmables Apr 5, 2017
@ericronne ericronne mentioned this pull request Apr 6, 2017
Merged
@gemfarmer gemfarmer changed the title [WIP] Tables schmables Tables schmables Apr 11, 2017
@gemfarmer gemfarmer requested a review from ericronne April 11, 2017 21:21
@ericronne
Copy link
Contributor

ericronne commented Apr 11, 2017 •
edited
Loading

@gemfarmer if you want to try and bring that material variance table into line with the other style, i'm game to see how it works!

Eric Ronne added 2 commits April 14, 2017 13:57
Applies green-underline table format to reconciliation
3760939 
Brought this table into line with others, style wise, and eliminated
the ` article_table-gray ` class, which is now used nowhere.

**Note: I couldn’t find what’s causing the gray fill on the table
header. Help!**
Removed gray bg from reconciliation table
5d43a95 
We may now be mergeable! 🙏
@ericronne ericronne merged commit a1a3f17 into dev Apr 17, 2017
@gemfarmer gemfarmer deleted the tables-redux branch April 17, 2017 21:06
@gemfarmer gemfarmer mentioned this pull request Apr 17, 2017
Merged
@meiqimichelle meiqimichelle mentioned this pull request Apr 18, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericronne ericronne Awaiting requested review from ericronne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gemfarmer @ericronne