This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
Various table format adjustments #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Equalized top and bottom cell padding - Changed indenting method to padding-left - Added styling for the “sup” class, which enabled me to shift the superscript numbers slightly down, as well as adding a little spacing on the left (so they don’t almost hit the adjacent text) - Tightened up the table line height a bit On these tables, we still need to adjust the leading for lines which have footnotes. (The number forces line heights to be too generous.) Definitely high likelihood of syntax glitches here! :fingers crossed: More to come!
houndci-bot
reviewed
Apr 6, 2017
_sass/components/_footnotes.scss
Outdated
| @@ -57,6 +57,13 @@ body { | |||
| vertical-align: super; // 2 | |||
| } | |||
|
|
|||
| sup { | |||
| padding-left: $base-padding-lite /2; | |||
| vertical-align: baseline; | |||
There was a problem hiding this comment.
Properties should be ordered padding-left, position, top, vertical-align
_sass/components/_footnotes.scss
Outdated
| @@ -57,6 +57,13 @@ body { | |||
| vertical-align: super; // 2 | |||
| } | |||
|
|
|||
| sup { | |||
| padding-left: $base-padding-lite /2; | |||
There was a problem hiding this comment.
$base-padding-lite /2 should be written with a single space on each side of the operator: $base-padding-lite / 2
|
Preview links don't work 🐰 |
|
Links work! Federalist auth issue. Resolved, thx @gemfarmer! |
houndci-bot
reviewed
Apr 7, 2017
_sass/components/_footnotes.scss
Outdated
| @include font-size(0.75); | ||
|
|
||
| color: $blue; | ||
| line-height: $base-font-size; |
There was a problem hiding this comment.
Properties should be ordered color, font-weight, line-height, vertical-align
gemfarmer
approved these changes
Apr 7, 2017
gemfarmer
changed the title
gemfarmer
pushed a commit
that referenced
this pull request
Apr 18, 2017
* started portin navs * Official Website banner: simplified. * Update _variables.scss * working nav, added to corporate income tax * downloads hompage * Evened out the vertical spacing * Reordered property cuz hound * Padding adjustments, breakpoint fix * Removed antialiasing from official banner type, and changed to book weight * Changed mid-table rules from green to light gray * Equalized vertical spacing for header * Meant to commit this, too * Added 3px right margin to flag * Increased contrast of map greens * Brings link/button blue into 508 compliance over $pale-gray * different bar style for negatives * intcomma_dollar * remove debuggin * Fixes vanishing Official banner on mobile * parens instead of - * hound * added 2016 data * added new revenue data * new data, associated documentation * note for future updates * added conditional for other revenue * alphabetize * Changed NGL to dark gray, to better stand out from the Gas and Oil bar colors * www.whitehouse.gov --> obamawhitehouse.archive.gov * add data with cents * updated file * file update * Darkened county fills on case-study maps Brings case-study map color into line with palette * migrate to federalist.fr.cloud.gov * 18F to 18f * update homepage oil rig svg * Darkens county and state outlines on case study maps * fix disappearing rig * Darkens green fills on state laws US map * Fixesd $green-darker color references and explore map gray outline bug * Changes US map on state laws pg to approximate $gray-light * Further lightens gray map outlines on case studies * outline.json * Various table format adjustments (#2249) * Various table format adjustments - Equalized top and bottom cell padding - Changed indenting method to padding-left - Added styling for the “sup” class, which enabled me to shift the superscript numbers slightly down, as well as adding a little spacing on the left (so they don’t almost hit the adjacent text) - Tightened up the table line height a bit On these tables, we still need to adjust the leading for lines which have footnotes. (The number forces line heights to be too generous.) Definitely high likelihood of syntax glitches here! :fingers crossed: More to come! * fixed footnote markdown bug * az * table schmables * table changes * Added new search fields (#2254) * added new search fields * coerce url * coerce url * coerce * Applies green-underline table format to reconciliation Brought this table into line with others, style wise, and eliminated the ` article_table-gray ` class, which is now used nowhere. **Note: I couldn’t find what’s causing the gray fill on the table header. Help!** * address broken internal links * Removed gray bg from reconciliation table We may now be mergeable! 🙏 * version bump
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this doesn't step on the toes of #2246 …
😎 PREVIEW
Sample: Corp income tax table
Changes proposed in this pull request:
superscript numbers slightly down, as well as adding a little spacing
on the left (so they don’t almost hit the adjacent text)
On these tables, we still need to adjust the leading for lines which
have footnotes. (The number forces line heights to be too generous.)
Definitely high likelihood of syntax glitches here! 🤞
More to come!