Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On genes panel page, make more evident which genes are new after the panel is updated #4957

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

northwestwitch
Copy link
Member

@northwestwitch northwestwitch commented Oct 17, 2024

This PR adds a functionality or fixes a bug.

image
Testing on cg-vm1 server (Clinical Genomics Stockholm)

Prepare for testing

  1. Make sure the PR is pushed and available on Docker Hub
  2. Fist book your testing time using the Pax software available at https://pax.scilifelab.se/. The resource you are going to call dibs on is scout-stage and the server is cg-vm1.
  3. ssh <USER.NAME>@cg-vm1.scilifelab.se
  4. sudo -iu hiseq.clinical
  5. ssh localhost
  6. (optional) Find out which scout branch is currently deployed on cg-vm1: podman ps
  7. Stop the service with current deployed branch: systemctl --user stop scout.target
  8. Start the scout service with the branch to test: systemctl --user start scout@<this_branch>
  9. Make sure the branch is deployed: systemctl --user status scout.target
  10. After testing is done, repeat procedure at https://pax.scilifelab.se/, which will release the allocated resource (scout-stage) to be used for testing by other users.
Testing on hasta server (Clinical Genomics Stockholm)

Prepare for testing

  1. ssh <USER.NAME>@hasta.scilifelab.se
  2. Book your testing time using the Pax software. us; paxa -u <user> -s hasta -r scout-stage. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.
  3. (optional) Find out which scout branch is currently deployed on cg-vm1: conda activate S_scout; pip freeze | grep scout-browser
  4. Deploy the branch to test: bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
  5. Make sure the branch is deployed: us; scout --version
  6. After testing is done, repeat the paxa procedure, which will release the allocated resource (scout-stage) to be used for testing by other users.

How to test:

  1. On stage, test with the OMIM-AUTO panel version 36, where it was introduced a new gene

Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.

Review:

  • code approved by
  • tests executed by CR

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (d46a7e8) to head (eddd252).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4957   +/-   ##
=======================================
  Coverage   84.78%   84.78%           
=======================================
  Files         320      320           
  Lines       19339    19339           
=======================================
  Hits        16397    16397           
  Misses       2942     2942           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@northwestwitch northwestwitch marked this pull request as ready for review October 17, 2024 12:21
@northwestwitch northwestwitch changed the title On genes panel page, it's more evident which genes are new after the panel is updated On genes panel page, make more evident which genes are new after the panel is updated Oct 17, 2024
Copy link
Collaborator

@dnil dnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ Thank you, much clearer!

  • The same display appears to be made in the panel_pdf_simple, perhaps patch it there as well?

There are a couple of issues with the feature overall I think, but we don't have to fix it here.

It appears a little unfortunate that we don't mark the first database_entry_version, meaning that browsing back to v1 looks odd. I suspect the design idea is that I half want to fix it, but let's save that for when someone actually wants it. I also don't really see how someone could be confused about that for very long. v1 is v1. 🤷

It would be simple to just flag genes without a database_entry_version as "new", but we also don't appear to be updating database_entry_version on regular add pending operations. 🙄

@@ -180,7 +180,11 @@
<td>{{ gene.disease_associated_transcripts|join(', ') }}</td>
<td>{{ 'Yes' if gene.reduced_penetrance }}</td>
<td>{{ 'Yes' if gene.mosaicism }}</td>
<td>{{ gene.database_entry_version }}</td>
<td class="d-flex justify-content-center">
{% if gene.database_entry_version and gene.database_entry_version|string == panel.version|string %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also same in panel_pdf_simple! 😊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading image.png…

Copy link

@northwestwitch northwestwitch merged commit e20bd11 into main Oct 18, 2024
25 checks passed
@northwestwitch northwestwitch deleted the clearer_panel_gene_entry branch November 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry version for genes in OMIM-AUTO panel
2 participants