-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On genes panel page, make more evident which genes are new after the panel is updated #4957
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4957 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 320 320
Lines 19339 19339
=======================================
Hits 16397 16397
Misses 2942 2942 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ Thank you, much clearer!
- The same display appears to be made in the
panel_pdf_simple
, perhaps patch it there as well?
There are a couple of issues with the feature overall I think, but we don't have to fix it here.
It appears a little unfortunate that we don't mark the first database_entry_version
, meaning that browsing back to v1 looks odd. I suspect the design idea is that I half want to fix it, but let's save that for when someone actually wants it. I also don't really see how someone could be confused about that for very long. v1 is v1. 🤷
It would be simple to just flag genes without a database_entry_version
as "new", but we also don't appear to be updating database_entry_version
on regular add pending operations. 🙄
@@ -180,7 +180,11 @@ | |||
<td>{{ gene.disease_associated_transcripts|join(', ') }}</td> | |||
<td>{{ 'Yes' if gene.reduced_penetrance }}</td> | |||
<td>{{ 'Yes' if gene.mosaicism }}</td> | |||
<td>{{ gene.database_entry_version }}</td> | |||
<td class="d-flex justify-content-center"> | |||
{% if gene.database_entry_version and gene.database_entry_version|string == panel.version|string %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also same in panel_pdf_simple
! 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This PR adds a functionality or fixes a bug.
Testing on cg-vm1 server (Clinical Genomics Stockholm)
Prepare for testing
scout-stage
and the server iscg-vm1
.ssh <USER.NAME>@cg-vm1.scilifelab.se
sudo -iu hiseq.clinical
ssh localhost
podman ps
systemctl --user stop scout.target
systemctl --user start scout@<this_branch>
systemctl --user status scout.target
scout-stage
) to be used for testing by other users.Testing on hasta server (Clinical Genomics Stockholm)
Prepare for testing
ssh <USER.NAME>@hasta.scilifelab.se
us; paxa -u <user> -s hasta -r scout-stage
. You can also use the WSGI Pax app available at https://pax.scilifelab.se/.conda activate S_scout; pip freeze | grep scout-browser
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_scout -t scout -b <this_branch>
us; scout --version
paxa
procedure, which will release the allocated resource (scout-stage
) to be used for testing by other users.How to test:
Expected outcome:
The functionality should be working
Take a screenshot and attach or copy/paste the output.
Review: