Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry version for genes in OMIM-AUTO panel #4956

Closed
northwestwitch opened this issue Oct 17, 2024 · 12 comments · Fixed by #4957
Closed

Entry version for genes in OMIM-AUTO panel #4956

northwestwitch opened this issue Oct 17, 2024 · 12 comments · Fixed by #4957
Assignees
Labels

Comments

@northwestwitch
Copy link
Member

northwestwitch commented Oct 17, 2024

Perhaps we had this discussion already but I forgot. Entry version Is systematically set to the version before, for all genes. but it's wrong, no?

@dnil
Copy link
Collaborator

dnil commented Oct 17, 2024

You mean as in pending updates or after it's applied? Ah the auto one! I'll have a look, but laters! 😅

@northwestwitch
Copy link
Member Author

You mean as in pending updates or after it's applied? Ah the auto one! I'll have a look, but laters! 😅

No, like just now that you updated the panel via the command line

@dnil
Copy link
Collaborator

dnil commented Oct 17, 2024

Yes, got it at last, but no, I think it's all good. We only got 7 completely new genes this time, and they do appear as v31:
Screenshot 2024-10-17 at 11 33 41

@dnil
Copy link
Collaborator

dnil commented Oct 17, 2024

Compare e.g.
Screenshot 2024-10-17 at 11 36 36
Screenshot 2024-10-17 at 11 36 53

@northwestwitch
Copy link
Member Author

northwestwitch commented Oct 17, 2024

Yes, got it at last, but no, I think it's all good. We only got 7 completely new genes this time, and they do appear as v31:

But it's impossible that all the other genes were intrduced in v 30

@dnil
Copy link
Collaborator

dnil commented Oct 17, 2024

But it's impossible that all the other genes were intrduced in v 0.29

But they were not, compare POT1 above?

It would be cool to deep dive each gene and fetch the first appearance for each line, instead of current and last - but I'm kind of guessing it would be too slow right now unless we refactor it, like storing the first appearance in db on each panel, and set it on creation or the first time its re-computed if it doesn't exist already.

@dnil
Copy link
Collaborator

dnil commented Oct 17, 2024

It's like a linked list currently - you have to follow it back from the end to find the first node.

@northwestwitch
Copy link
Member Author

It would be cool to deep dive each gene and fetch the first appearance for each line, instead of current and last - but I'm kind of guessing it would be too slow right now unless we refactor it, like storing the first appearance in db on each panel, and set it on creation or the first time its re-computed if it doesn't exist already.

yes, that's what I mean. As we write it now, it seems that the genes were new in the panel before, but they weren't

@dnil
Copy link
Collaborator

dnil commented Oct 17, 2024

Not really, but I see how one could interpret that as such. What it does is expose some db internals which isn't super cute, but compare how you e.g. see the next pending update on earlier, frozen versions. It works as a diff, and a history, so all good and clever, but isn't super clear to a random user. It's exactly the same thinking with the gene revisions - or well, maybe lack thereof, and just reusing. 😁

@northwestwitch
Copy link
Member Author

Perhaps we could just find a smarter name for that column, lnstead of "entry version". Entry version/previous version or something?

@dnil
Copy link
Collaborator

dnil commented Oct 17, 2024

Perhaps, or a tooltip with a small essay? We could also hide the previous version number, or like super highlight the ones that match the selected panel version? The only thing the feature does realistically is show if a gene was changed with this version, or was there unchanged in the previous one.

@northwestwitch
Copy link
Member Author

I like the idea of hiding the field if it's old and having instead something "new in the panel version" for the new genes n the panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants