Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On genes panel page, make more evident which genes are new after the panel is updated #4957

Merged
merged 8 commits into from
Oct 18, 2024
Merged

On genes panel page, make more evident which genes are new after the panel is updated #4957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6ff8c01
On genes panel page, it's more evident which genes are new after the …
Oct 17, 2024
a7ed36d
slight fix
Oct 17, 2024
cc4d9fe
Improve the looks and add tooltip
Oct 17, 2024
52b8502
tyny tiny fix
Oct 17, 2024
4920bf3
Center badge in the cell
Oct 17, 2024
a32faa8
Merge branch 'main' into clearer_panel_gene_entry
dnil Oct 18, 2024
c7b94ae
modify also the PDF panel export, as per review
Oct 18, 2024
eddd252
Updated changelog
Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ This project adheres to [Semantic Versioning](http://semver.org/).

About changelog [here](https://keepachangelog.com/en/1.0.0/)


## [unreleased]
### Changed
- On genes panel page and gene panel PDF export, it's more evident which genes were newly introduced into the panel

## [4.90.1]
### Fixed
- Parsing Matchmaker Exchange's matches dates
Expand Down
6 changes: 5 additions & 1 deletion scout/server/blueprints/panels/templates/panels/panel.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,11 @@
<td>{{ gene.disease_associated_transcripts|join(', ') }}</td>
<td>{{ 'Yes' if gene.reduced_penetrance }}</td>
<td>{{ 'Yes' if gene.mosaicism }}</td>
<td>{{ gene.database_entry_version }}</td>
<td class="d-flex justify-content-center">
{% if gene.database_entry_version and gene.database_entry_version|string == panel.version|string %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also same in panel_pdf_simple! 😊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading image.png…

<span class="badge bg-success rounded-pill" data-bs-toggle="tooltip" data-bs-placement="right" data-bs-html="true" title="This gene has been introduced in the panel starting from version {{gene.database_entry_version}}.">new</span>
{% endif %}
</td>
<td>{{ gene.inheritance_models|join(', ') }}</td>
<td>{{ gene.custom_inheritance_models|join(', ') }}</td>
<td>{{ gene.comment }}</td>
Expand Down
6 changes: 5 additions & 1 deletion scout/server/blueprints/panels/templates/panels/panel_pdf_simple.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,11 @@ <h4>Scout - Gene panel report</h4> - created on:&nbsp;<strong>{{report_created_a
<td>{{ gene.disease_associated_transcripts|join(', ') }}</td>
<td>{{ 'Reduced penetrance' if gene.reduced_penetrance }}</td>
<td>{{ 'Mosaicism' if gene.mosaicism }}</td>
<td>{{ gene.database_entry_version }}</td>
<td>
{% if gene.database_entry_version and gene.database_entry_version|string == panel.version|string %}
<span class="badge bg-success rounded-pill">new</span>
{% endif %}
</td>
<td>{{ gene.inheritance_models|join(', ') }}</td>
<td>{{ gene.custom_inheritance_models|join(', ') }}</td>
<td>{{ gene.comment }}</td>
Expand Down
Loading