add lengthscale functions to mesh and spaces #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
force-pushed
the
sb/lengthscale
branch
from
d51858e to
49e5e26
Compare
|
bors try |
tryBuild failed: |
simonbyrne
force-pushed
the
sb/lengthscale
branch
from
eef5789 to
068a522
Compare
|
bors try |
simonbyrne
force-pushed
the
sb/lengthscale
branch
from
068a522 to
8978a54
Compare
|
bors try |
tryAlready running a review |
|
bors try |
simonbyrne
commented
May 30, 2022
Comment on lines
113
to
114
| c = sqrt(parameters.g * parameters.ρ₀) | ||
| D₄ = 0.0015 * c * Spaces.lengthscale(space)^3 # hyperdiffusion coefficient |
There was a problem hiding this comment.
@paullric Is this an appropriate way to choose the hyperdiffusion coefficient for the shallow water equations?
|
Yes that should work for most scales.
… On May 29, 2022, at 10:38 PM, Simon Byrne ***@***.***> wrote:
@simonbyrne commented on this pull request.
In examples/bickleyjet/bickleyjet_cg_invariant_hypervisc.jl <#739 (comment)>:
> + c = sqrt(parameters.g * parameters.ρ₀)
+ D₄ = 0.0015 * c * Spaces.lengthscale(space)^3 # hyperdiffusion coefficient
@paullric <https://github.com/paullric> Is this an appropriate way to choose the hyperdiffusion coefficient for the shallow water equations?
—
Reply to this email directly, view it on GitHub <#739 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIVPZCYVK6P47HPUYP7B53VMRH6PANCNFSM5XIUEJXA>.
You are receiving this because you were mentioned.
|
|
bors try |
valeriabarra
previously requested changes
Jun 13, 2022
4 tasks
|
If using the cubed sphere it depends as well where you measure the min node distance. Shortest distances occur along cubed-sphere edges in the middle, where grid points are roughly sqrt(3)/2 closer together than nodes in the panel center. But if using regional refinement then you need to assess node distance everywhere.
~ Paul
… On May 31, 2022, at 1:27 PM, Valeria Barra ***@***.***> wrote:
@valeriabarra commented on this pull request.
In src/Meshes/Meshes.jl <#739 (comment)>:
>
+The approximate lengthscale of the elements of the mesh.
+"""
+function lengthscale end
In addition to this, I think it will also be important to add the min node distance to facilitate the CFL condition / Courant number calculation
—
Reply to this email directly, view it on GitHub <#739 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIVPZBYUO6ZYKIQ3LOALHTVMZY4XANCNFSM5XIUEJXA>.
You are receiving this because you were mentioned.
|
simonbyrne
force-pushed
the
sb/lengthscale
branch
from
8d3b303 to
c2c73f4
Compare
There was a problem hiding this comment.
LGTM, we may just want to get #1581 in first and rebase this.
|
I'll go ahead and rebase this cc @simonbyrne |
charleskawczynski
force-pushed
the
sb/lengthscale
branch
from
95438f3 to
1ddb424
Compare
simonbyrne
force-pushed
the
sb/lengthscale
branch
2 times, most recently
from
3c8c2a0 to
1c8dae7
Compare
simonbyrne
force-pushed
the
sb/lengthscale
branch
from
4086441 to
29b3f6b
Compare
szy21
reviewed
Jan 4, 2024
| @@ -5,7 +5,7 @@ agents: | |||
|
|
|||
| env: | |||
| JULIA_LOAD_PATH: "${JULIA_LOAD_PATH}:${BUILDKITE_BUILD_CHECKOUT_PATH}/.buildkite" | |||
| JULIA_DEPOT_PATH: "${BUILDKITE_BUILD_PATH}/${BUILDKITE_PIPELINE_SLUG}/depot/default" | |||
| # JULIA_DEPOT_PATH: "${BUILDKITE_BUILD_PATH}/${BUILDKITE_PIPELINE_SLUG}/depot/default" | |||
There was a problem hiding this comment.
Just noticed this. Is this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make CliMA/ClimaAtmos.jl#491 easier