Add hyperviscosity conversion for CAM-SE model #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapios
reviewed
Dec 20, 2023
There was a problem hiding this comment.
The paper also uses `divergence_damping_factor = 5'.
@szy21 is implenting a hyperdiffusion formulation (based on the physical grid spacing) that will no longer need this. Depending on when she'll be done, we may not need this.
|
The grid-spacing-dependent hyperdiffusion needs ClimaCore 739, so it will take slightly longer. If you need something now this is good. |
|
I'll merge this in, as the ClimaCore PR for minimum nodal distance has not been merged yet. We can remove this later. |
szy21
force-pushed
the
ck/div_damping
branch
from
2d8135f to
a3ab66f
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@akshaysridhar You can use this if you want to follow CAM hyperdiffusion. |
|
Noted thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a conversion for the CAM-SE hyperviscosity. I plan to use this in the parameter sweeps.