Remove duplicate quadratures module #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/cleanup
branch
from
6800ed5 to
46879c5
Compare
charleskawczynski
force-pushed
the
ck/cleanup
branch
from
46879c5 to
2dc2b09
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently two Quadratures modules (with the exact same contents). I think this was accidentally left over in the big Grids PR. Duplicating code isn't always a bad thing but I think, in this case, it's somewhat problematic because types defined in these two modules have their own identity, so passing the wrong one can result in incorrect/unintended dispatch.
Found in an error in #739 build.