Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more zombies wear wedding rings #76852

Merged
merged 3 commits into from
Oct 6, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Content "Make more zombies wear wedding rings"

Purpose of change

Wedding rings are very rare in zombie loot compared to how many people you see wearing them in real life.

Describe the solution

Add wedding rings to default_zombie_clothes. The percentage is somewhat of a guesstimate--while the stats of percentage of adults who are married are available (~50% in America), there's no easy information for "percentage of married adults who do not wear their ring," so I went with 2/3rds of that 50% wear their ring, leading to a 33% drop rate.

Describe alternatives you've considered

Testing

Killed some zombies, found wedding rings.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 6, 2024
@NetSysFire
Copy link
Member

I would not be surprised if the spawn rate was cut back when we did not have subtypes for loot and zombie children were spawning with wedding dresses and rings and other inappropriate stuff.

I looked into the code and I am unsure whether or not that change applies to zombie children, as they are copied from the zombie base template which uses that loot group. Please make sure these do not spawn on them.

@Standing-Storm
Copy link
Contributor Author

Zombie children do copy from zombie base, but they override the death drops with their own special loot group.

Results of the most common drops in the zombie child clothes loot group:

Untitled2

No wedding rings.

(some oddities, though--union suits?)

@PatrikLundell
Copy link
Contributor

I haven't been playing actively for a while, but wedding rings were encountered all over the place, including weird cases where multiple wedding rings were worn. Serial marriage trophies (is that a thing?)? Polygamy? ...

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 6, 2024
@Night-Pryanik
Copy link
Contributor

This shouldn't break anything, so let's merge this.

@Night-Pryanik Night-Pryanik merged commit 818c3ef into CleverRaven:master Oct 6, 2024
26 checks passed
@Standing-Storm Standing-Storm deleted the married-zombies branch October 6, 2024 18:07
@Standing-Storm
Copy link
Contributor Author

I haven't been playing actively for a while, but wedding rings were encountered all over the place, including weird cases where multiple wedding rings were worn. Serial marriage trophies (is that a thing?)? Polygamy? ...

Wedding rings are a possible drop, but it looks like from generic zombie clothes it's a 15% chance to pull from accesories_personal_unisex, in which wedding rings have "prob": 1

accessory_ring might be what you're thinking of, since it has { "item": "ring_wedding", "prob": 50, "count": [ 1, 2 ] } right at the top, but...apparently it's not referenced anywhere? Doing a search for it only pulls up the group definition and an Aftershock copy-from to add titanium rings, nothing else.

@PatrikLundell
Copy link
Contributor

I don't know where it came from, only that I've seen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants