-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace baby_egg, baby_monster, baby_monster_group with struct #76266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Code: Tests
Measurement, self-control, statistics, balancing.
[C++]
Changes (can be) made in C++. Previously named `Code`
Monsters
Monsters both friendly and unfriendly.
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Aftershock
Anything to do with the Aftershock mod
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: Defense Mode
Anything to do with the Defense Mode mod
Mods: TropiCataclysm 🌴
Having to do with the tropical region mod for DDA.
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods: Mind Over Matter
json-styled
JSON lint passed, label assigned by github actions
labels
Sep 7, 2024
GuardianDll
force-pushed
the
baby_struct
branch
from
September 7, 2024 21:20
b9ddd9d
to
276a287
Compare
GuardianDll
force-pushed
the
baby_struct
branch
from
September 7, 2024 21:27
276a287
to
825c03b
Compare
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
[Markdown]
Markdown issues and PRs
astyled
astyled PR, label is assigned by github actions
labels
Sep 7, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Sep 8, 2024
No gods no kings no tests! Do you want me to wait until the test PR is also passing? |
Nope, test relies on yet another PR by Ren, that's partially the reason i moved it to separate pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Tests
Measurement, self-control, statistics, balancing.
<Documentation>
Design documents, internal info, guides and help.
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mods: Aftershock
Anything to do with the Aftershock mod
Mods: Defense Mode
Anything to do with the Defense Mode mod
Mods: Dinomod
Anything to do with the Dinoclysm mod (DinoMod)
Mods: Magiclysm
Anything to do with the Magiclysm mod
Mods: Mind Over Matter
Mods: TropiCataclysm 🌴
Having to do with the tropical region mod for DDA.
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Monsters
Monsters both friendly and unfriendly.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
having three (now four) different field that need to be compared against each other all the time? let's just move it to something better
Describe the solution
Shove baby_egg, baby_monster, baby_monster_group to struct
Add new type,
baby_egg_group
Compare each one against each other to prevent user using more than one by accident
replace all json syntax with regex (something like
"baby_egg": "(.*?)"
and"baby_type": { "baby_egg": "$1" }
)replace all using in code using the struct
finish unit testmoved to Make reproduction CI test #76294Testing
1
spawn eggs2
spawn books from itemgroup3
spawn dogs4
spawns cats from cat group