Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux binaries fail to compile in GitHub releases after #76266 #76357

Closed
redcrate opened this issue Sep 11, 2024 · 5 comments · Fixed by #76363
Closed

Linux binaries fail to compile in GitHub releases after #76266 #76357

redcrate opened this issue Sep 11, 2024 · 5 comments · Fixed by #76363
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@redcrate
Copy link

Describe the bug

Linux Binaries are not generating after #76266

Attach save file

N/A

Steps to reproduce

N/A

Expected behavior

I expect all standard binaries to generate after a code update.

Perhaps it would be a good idea for GitHub to run a test to see how many files are generated after a commit.

Screenshots

image

Versions and configuration

N/A

Additional context

No response

@redcrate redcrate added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Sep 11, 2024
@harakka
Copy link
Member

harakka commented Sep 12, 2024

Perhaps it would be a good idea for GitHub to run a test to see how many files are generated after a commit.

And to do what with that information? It is considered acceptable for experimental that a particular build breaks sometimes in experimental releases, if you want to find the last complete release it is linked on the game's website.

@ZweiFedern
Copy link

ZweiFedern commented Sep 12, 2024

There is a Problem at the Build - GCC 9, Curses, LTO - get an Error, and so the Build for Linux (ubuntu) get cancelled.
The Later Builds for Linux were all cancelled. I have seen in the newest Build Progress, that there is an Error.
(Error: src/mtype.h:320:19: error: declaration of ‘baby_type mtype::baby_type’ changes meaning of ‘baby_type’ [-fpermissive])
Bildschirmfoto vom 2024-09-12 10-39-45

@harakka
Copy link
Member

harakka commented Sep 12, 2024

Yes, #76363 is already up to fix this particular instance of a particular build breaking.

@redcrate
Copy link
Author

Perhaps it would be a good idea for GitHub to run a test to see how many files are generated after a commit.

And to do what with that information? It is considered acceptable for experimental that a particular build breaks sometimes in experimental releases, if you want to find the last complete release it is linked on the game's website.

I am aware that in experimental that things don't always work. However, as part of the development process, the information could be used to notify the committer that their update isn't working properly and would just be another CI/CD check. The possibilities are endless...

@kevingranade
Copy link
Member

If you have a proposal for a workable mechanism to close this feedback loop, feel free to recommend it, but "notify people somehow" isn't a meaningful suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants