Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reproduction CI test #76294

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Sep 8, 2024

Summary

None

Purpose of change

There is no reason to hold back #76266 because i can't get what's wrong with the test i made

Describe the solution

Move the test from #76266 here

Testing

image

Additional context

Relies on #76266 for obv reasons, and relies on #76264 because otherwise i'd need to do shenanigans with unloading and loading monster back

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. labels Sep 8, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Sep 8, 2024
@mqrause
Copy link
Contributor

mqrause commented Sep 8, 2024

try_reproduce doesn't actually spawn monsters, it just tells the map to spawn them on the next occasion. So calling spawn_monsters on the map after try_reproduce should probably fix it.

@GuardianDll
Copy link
Member Author

what about failing monsters_spawn_egg_itemgroups? this one spawns items, and... oh right, it's probably because spawn_items() works only outside of bub. How would i do it then? run try_reproduce(), then teleport avatar afar, and then teleport them back?

@mqrause
Copy link
Contributor

mqrause commented Sep 8, 2024

I was looking at this run, which didn't fail for eggs.

@GuardianDll
Copy link
Member Author

🤔
i'll come back to this PR when previous two will be merged

@GuardianDll GuardianDll marked this pull request as ready for review November 13, 2024 21:30
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 14, 2024
Co-authored-by: Anton Burmistrov <[email protected]>
@ZhilkinSerg ZhilkinSerg merged commit 2e77ec1 into CleverRaven:master Nov 15, 2024
19 of 27 checks passed
@GuardianDll GuardianDll deleted the test_for_repro branch November 15, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants