jmapgen itemgroup item default chance #72458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @Night-Pryanik
github-actions
bot
added
astyled
Procyonae
commented
Mar 25, 2024
github-actions
bot
added
<Bugfix>
github-actions
bot
added
the
json-styled
Maleclypse
reviewed
Mar 29, 2024
Maleclypse
reviewed
Mar 29, 2024
github-actions
bot
added
json-styled
Procyonae
force-pushed
the
JMapgenItemDefaultChance
branch
from
2fc3ae9 to
322bdad
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
BasicBuildPassed
|
Self reminder to do this with place_vehicles too once it's merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #72326
Describe the solution
Changes
"items":"chance"field to default to 100 in 100 rather than 1 in 100 as this is very unintuitive, if you don't specify a chance you'd expect it to always spawn not almost never.Updates the docs to reflect this
Adds
"chance": 1to the clutter groups that appear to be the only things intentionally using the old default.Throws an error if
"prob"is used in"items":asking for it to be replaced with chance.Attempts to replace all existing instances of this.
Describe alternatives you've considered
Ideally both
"item":and"items":chances would work the same and ideally be x in y imo rather than 1 in x and x in 100 respectively but that would be incredibly disruptive to the codebases git history for little gain.Short of that ideally all the now meaningless
"chance": 100s would be removed but just in vanilla there's 1000s which again seems very disruptive for an tiny gain.Testing
Additional context