Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes "items": "chance" field now to defaults to 100 in 100 rather than 1 in 100 #172

Closed
hexagonrecursion opened this issue Apr 25, 2024 · 1 comment

Comments

@hexagonrecursion
Copy link
Contributor

It appears the interpretation of itemgroup entries that do not explicitly specify chance has changed. See CleverRaven/Cataclysm-DDA#72458. cdda-guide may need an audit to make sure this case is consistent with how the game handles it.

@nornagon
Copy link
Owner

nornagon commented May 3, 2024

oof, that's a rough change, thanks for bringing it to my attention.

fortunately(?), I think HHG has been incorrect until now, and that PR brings CDDA in line with HHG 😁 I, too, must have assumed that the default was to spawn the item 100% of the time.

@nornagon nornagon closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants