Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Reduce preserved food in druid tower #74194

Merged
merged 1 commit into from
May 31, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented May 30, 2024

Summary

Bugfixes "[Magiclysm] Reduce preserved food in druid tower"

Purpose of change

I think the switch from prob to chance changed the way the drop rates were calculated because there is way too much food there now.

Describe the solution

Reduce the food to around 8% of how much it was. These are druids, they'd have ways to get food from nature that don't involve preserving it.

Describe alternatives you've considered

Testing

Checked druid tower, amount of food is still sizable but no longer months worth for a single person.

Additional context

Copy link
Member

@RenechCDDA RenechCDDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual chance was 1% by accident when it was defined as prob (was read but unused)

In #72458 the prob values were switched directly to chance, assuming that the previous values were intended as % chances.

Way too much food when the chance is actually 40% (~40x what was there previously). 👍

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod <Bugfix> This is a fix for a bug (or closes open issue) labels May 30, 2024
@github-actions github-actions bot requested a review from KorGgenT May 30, 2024 16:45
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 30, 2024
@Maleclypse Maleclypse merged commit 195182f into CleverRaven:master May 31, 2024
27 of 28 checks passed
@Standing-Storm Standing-Storm deleted the less-druid-food branch May 31, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants