-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Zed Bits #71931
Merged
Maleclypse
merged 11 commits into
CleverRaven:master
from
TheSaddestGoomba:Boomer-Polish
Feb 27, 2024
Merged
Cleanup Zed Bits #71931
Maleclypse
merged 11 commits into
CleverRaven:master
from
TheSaddestGoomba:Boomer-Polish
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add snippets for tainted arm, tainted leg, and tainted human skull
-Created a new harvest group and description group for headless zombies and assigned them. The generic version includes a skull item now. Several of the generic snippets directly reference a head, brain, or teeth. -Created a new harvest group for fusion zeds to butcher for more than one skull. -Added bones, marrow, and sinew to flesh golem and jabberwock harvests. Also added a chance for several skulls to jabberwock.
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Feb 23, 2024
This is rough and throwing an error (invalid alpha talker), but working. Death functions call new spells which call existing boomer death effects and a new EoC that places filthy clothes from the default zombie death drops item group.
github-actions
bot
added
Monsters
Monsters both friendly and unfriendly.
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Feb 24, 2024
-Set the new snippets to be called by their respective items -Linting
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Feb 24, 2024
-Create a few new death drops -Create version of boomer clothes drop for the snotgobbler -Apply these to the following monsters: 1. Snotgobbler 2. Zombie Hollow 3. Unstable Raptor 4. Fungal Skeletal Zombie 5. Fungal Skeletal Brute 6. Fungal Juggernaut 7. All four sizes of Meat Cocoon
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Feb 25, 2024
Remove copy_from from tainted limbs to avoid vitamin inheritance.
-Adds tainted human skull as a component option for skull bowls. -Adds tainted innards as a component option for base mutagen.
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Containers
Things that hold other things
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Monsters
Monsters both friendly and unfriendly.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Cleanup zombie harvest lists and polish tainted body parts."
Purpose of change
Cleanup changes made in #71862 and add new tainted parts to relevant recipes.
Describe the solution
Explore options for making clothing left by NO_CORPSE mobs spawn as FILTHY.Explore options for making drops spawned by exploding enemies scatter to nearby tiles.Describe alternatives you've considered
Testing
Much. Many repeated spawnings of relevant monsters, followed by their mass executions.
Exploding enemies leave the intended items on death effect (with the exception of clothing not being filthy).
Butchered enemies produce the appropriate items.
Recipes work as intended.
Snippets appear in the right places.
Additional context
Partly a follow-up to: #71862