Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Zed Bits #71931

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Cleanup Zed Bits #71931

merged 11 commits into from
Feb 27, 2024

Conversation

TheSaddestGoomba
Copy link
Contributor

@TheSaddestGoomba TheSaddestGoomba commented Feb 23, 2024

Summary

Content "Cleanup zombie harvest lists and polish tainted body parts."

Purpose of change

Cleanup changes made in #71862 and add new tainted parts to relevant recipes.

Describe the solution

  • Updated missed enemies to match previous changes:
  1. Snotgobbler
  2. Unstable Raptor
  3. Fungal Skeleton Zombie
  4. Fungal Skeleton Brute
  5. Fungal Juggernaut
  6. Tiny Meat Cocoon
  7. Small Meat Cocoon
  8. Large Meat Cocoon
  9. Gigantic Meat Cocoon
  10. Zombie Hollow
  • Add snippets for tainted arm, tainted leg, and tainted human skull.
  • Add tainted skin scraps mostly for Zombie Hollow, but added to others as appropriate.
  • Add new harvest and snippet description groups for Headless Zombies.
  • Adjust harvest entries for Flesh Golem and Jabberwock.
  • Add new harvest group for the Crawler and Dissoluted Devourer.
  • Add tainted innards and tainted human skull to relevant recipes.
  • No such luck. Explore options for making clothing left by NO_CORPSE mobs spawn as FILTHY.
  • Second verse. Explore options for making drops spawned by exploding enemies scatter to nearby tiles.

Describe alternatives you've considered

  • Making adjustments to the many fungal structure monsters that leave no corpse. There are many and it's not clear what should be left behind when they're destroyed.
  • Including the missile spider and the caustic and bilious zombie soldiers. The latter two leave corpses despite having a death function with no corpse. I have no idea what's up with the former, the spider explodes, like fiery explosion and ignites the ground.

Testing

Much. Many repeated spawnings of relevant monsters, followed by their mass executions.
Exploding enemies leave the intended items on death effect (with the exception of clothing not being filthy).
Butchered enemies produce the appropriate items.
Recipes work as intended.
Snippets appear in the right places.

Additional context

Partly a follow-up to: #71862

Add snippets for tainted arm, tainted leg, and tainted human skull
-Created a new harvest group and description group for headless zombies and assigned them. The generic version includes a skull item now. Several of the generic snippets directly reference a head, brain, or teeth.
-Created a new harvest group for fusion zeds to butcher for more than one skull.
-Added bones, marrow, and sinew to flesh golem and jabberwock harvests. Also added a chance for several skulls to jabberwock.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 23, 2024
This is rough and throwing an error (invalid alpha talker), but working.

Death functions call new spells which call existing boomer death effects and a new EoC that places filthy clothes from the default zombie death drops item group.
@github-actions github-actions bot added Monsters Monsters both friendly and unfriendly. and removed BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Feb 24, 2024
-Set the new snippets to be called by their respective items
-Linting
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A fat zombie haunch. It doesn't look tasty but the shape is undeniably close to a large fried chicken leg. The skin is even the right texture, though for the wrong reasons.
  • Little tainted meat remains on whatever limb bones these were. It still bends at the joint but doesn't look to be moving on its own anymore.
  • The brain has ossified inside this tainted skull. It doesn't feel noticeably heavier and you surmise that the brain-turned-bone must be deeply porous or hollow itself.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 24, 2024
-Create a few new death drops
-Create version of boomer clothes drop for the snotgobbler
-Apply these to the following monsters:
1. Snotgobbler
2. Zombie Hollow
3. Unstable Raptor
4. Fungal Skeletal Zombie
5. Fungal Skeletal Brute
6. Fungal Juggernaut
7. All four sizes of Meat Cocoon
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 25, 2024
Remove copy_from from tainted limbs to avoid vitamin inheritance.
-Adds tainted human skull as a component option for skull bowls.
-Adds tainted innards as a component option for base mutagen.
@github-actions github-actions bot added the Items: Containers Things that hold other things label Feb 25, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 26, 2024
@TheSaddestGoomba TheSaddestGoomba marked this pull request as ready for review February 26, 2024 04:15
@Maleclypse Maleclypse merged commit efec09a into CleverRaven:master Feb 27, 2024
39 checks passed
@TheSaddestGoomba TheSaddestGoomba deleted the Boomer-Polish branch February 27, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants