-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrites Lore Inconsistent Profession Descriptions #71877
Conversation
"name": "Soccer Player", | ||
"description": { | ||
"male": "Soccer, rugby — whatever you term it, you'd played it extensively before the Cataclysm and were quite the sportsman. Now, your trade has left you with a set of football armour that you'd packed along during the evacuation, a strong throwing arm, and experience in pitch-side tussling. With your ball at your side, the only keepsake you'd been able to hold on to through the end of days, you suppose that it's time to hustle.", | ||
"female": "Soccer, rugby — whatever you term it, you'd played it extensively before the Cataclysm and were quite the sportswoman. Now, your trade has left you with a set of football armour that you'd packed along during the evacuation, a strong throwing arm, and experience in pitch-side tussling. With your ball at your side, the only keepsake you'd been able to hold on to through the end of days, you suppose that it's time to hustle." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is quite what @TheShadowFerret had in mind with their review, rather than eliminating any mention of US football, you should have eliminated any mention of other sports that were not US football, since the profession is clearly representing an American football player, not a soccer player or a rugby one.
Late, but you can use the Safe Place scenario and select the refugee center at the last screen of character generation. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
I am interested in helping with this concept, should I pull against your branch? |
To be honest, I was thinking about up and resolving any remaining conflicts and presenting this PR as part 1 of a line of changes, as I’m in university exam season and the time I have to budget to touch this branch is limited until the end of June. I’ll probably be around for any discussion or modest-scale work, but if you would like to work strait on this branch with the 40 odd professions still left, you’re more than welcome. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
@DoctorBoomstick I've picked this back up! I have a different writing style than you, so I mostly used your rewrites as something to work off of, but they were still informative in how to look at the professions in a different light. At this moment in time, I've recreated most of what was done here already in my own style. Due to the age of this PR, there were a number of things that were broken as the code shifted, so my PR isn't so much a continuation of yours as much as it is a spiritual successor to it. I'm not going to be posting a draft though, personally I don't like people seeing my work until it's in a presentable state, as I often fiddle with things all the way to the last minute and there would just be scores of little commits. I'll just put it up when I'm finished in a week or two. It should go without saying that I'll credit you! |
Summary
None
Purpose of change
As ilistrated within issue #71679, many in-game descriptions for things that are not designed to be unreliable narrators are, nevertheless, inconsistent with current game lore, whether referencing content that was dropped years ago or not reflecting that the Cataclysm was a long, drawn-out event that took place over several weeks rather than a few moments. Pr #71726 started by rewriting the more obviously incongruent scenario descriptions, but profession descriptions are, perhaps, the most conspicuous in the latter respect, with many of them insinuating that the player character was going about their normal day when, like my obese character crashing off the roof of a private resort, the mystical cataclysm happened. This does not properly represent game lore. This being said, in-game lore means nothing if in-game sources don’t abide by it.
Describe the solution
I will rewrite the descriptions that I deem to be out of place considering current standing lore, with many descriptions either requiring small adjustments, sentence removals, or complete rewrites. In addition, I will also be vetting the equipment that some of these professions start with, at least the ones that are quite nonsensical. Why is the novice martial artist wearing their sparring uniform despite several weeks of unrest, evacuations, and a plummeting sky? Why do the swimmer professions elect to keep wearing their swimwear despite monsters the size of skyscrapers idly walking over their houses and the sea boiling? Why is the office worker just lugging around an entire coffee pot filled with still-warm coffee? I am either far too stupid to answer these deep, deep questions, or something might need a bit of the old pen medicine.
I have chosen the roster of descriptions to be edited based on whether they seem to indicate an end-of-world scenario that took place swiftly, like a classic zombie-style outbreak, or if they describe the player character going about their normal work despite the world literally eating itself and their jobs having been rendered untenable weeks before the game started. I have excluded professions such as the patriot, prepped patriot, food person, and hitchhiker because, while their starting equipment makes little sense, they are expressly meant to be joke professions: as apposed to bride Maggy, who was a normal, working person before the end of the world but decided to remain in her bride’s clothes throughout months of violence, an evacuation order, the sky splitting open, the government collapsing, and subsequent days of a literal elder god haemorrhaging the world.
As of now, I’ve chosen to open up this PR on draft to keep track of which professions require work, as well as to leave the door open for actual lore people to strowl in and comment over whether the newly coming descriptions adhere to the lore: I am a simple man, not a loreman. I would also appreciate thoughts on whether I’ve left some offending professions off the roster or if particular professions not referenced here also have peculiar starting equipment choices. Now, ladies and gentlemen, the list of professions is as follows:
Describe alternatives you've considered
Not opening this PR on draft but just frontloading all the new descriptions once they’re ready. I feel like this is a better incentive to keep me motivated, a good way to track progress, and a means to not waste anyone's time if I write descriptions that are nonsensical, dumb, lore-breaking, emersion-shattering, etc. etc.
Testing
Work in progress.
Additional context
consult issue #71679 for the original issue.