-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrites Lore Inconsistent Profession Descriptions #71877
Closed
Closed
Changes from 38 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
97c423d
fixes merge errors.
DoctorBoomstick ad9a35b
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick f243460
Merge branch 'master' of https://github.com/DoctorBoomstick/Cataclysm…
DoctorBoomstick c85a281
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 9d40bd7
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick e3eb338
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick e03c3a4
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick d006c4e
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick df5f709
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 6002b70
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick eabc64e
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 4b38a26
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 3202fd6
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 407f8eb
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 55c0b70
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick de0154c
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 4984eeb
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick a0e7e2c
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick f80539e
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 397de31
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 4cbf7e7
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick fae5975
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 328362f
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 31dd3ad
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 1da0174
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick bdf7be4
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 78102e7
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 7802607
Completes first batch, basketball player, football player, police off…
DoctorBoomstick 58e48eb
Revamps the Police detective
DoctorBoomstick ea0136a
Cleans out the motorised police officer and hill billie.
DoctorBoomstick c5cc8e5
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick cbdde6e
Merge branch 'master' into PD
DoctorBoomstick 1a55af0
replaces ’ with '
DoctorBoomstick 5677145
trucker cleaned out.
DoctorBoomstick 4d0c3df
Update data/json/professions.json
DoctorBoomstick 2bbc216
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 73156aa
Merge branch 'master' into PD
DoctorBoomstick 153618f
cleans out the ride share driver and parremedic firefighter.
DoctorBoomstick cab1029
fixes ’ versus ' nonsence.
DoctorBoomstick aaf214b
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick bed78c2
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 6b2da32
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 63b6899
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick d8569d4
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick f192031
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 8f28ad0
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 7d3be33
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 3a24916
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick 7a930f8
Merge remote-tracking branch 'upstream/master'
DoctorBoomstick af542a1
Merge branch 'master' into PD
DoctorBoomstick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is quite what @TheShadowFerret had in mind with their review, rather than eliminating any mention of US football, you should have eliminated any mention of other sports that were not US football, since the profession is clearly representing an American football player, not a soccer player or a rugby one.