Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrites Lore-Inconsistent Scenario Descriptions #71726

Merged
merged 38 commits into from
Feb 20, 2024

Conversation

DoctorBoomstick
Copy link
Contributor

@DoctorBoomstick DoctorBoomstick commented Feb 12, 2024

Summary

None

Purpose of change

As described within issue #71679, some scenario descriptions fail to take into account the gaps in events, the overall timeline, and the general buildup of global unrest present within the backstory of Cataclysm. Largely, most of these descriptions make it sound like the Cataclysm was a magnanimous, single event that happened over the course of minutes rather than weeks, as reported by our lore. Considering that lore is no good to anybody if in game UI sources not built to be unreliable narrators blatantly laugh in it’s face, I have taken the pen and a sheet of paper, ditched them because they’re useless for making a digital PR, and rewrote the descriptions for the scenarios pointed out in the linked issue.

Describe the solution

Thus far, I have rewritten:

  • The description for the Mascot Rises scenario.
  • The description and associated mission for the Last Delivery scenario.
  • The description for the Crazy Party scenario (wondering if I should change it’s name).
  • The description for the low-profile scenario.

I have elected to leave this PR on draft, as I’m still a tad unsure about some of the current descriptions and whether it would be wise to rewrite them as well, namely any description that mentions an “initial wave of panic,” such as the evacuee scenario. I’m also keeping an eye on some of the profession listings. Looking at you, crazy party. I’d appreciate it if lore-department people could roll into this PR and leave their thoughts over what, if anything else, should be changed while we’re playing around with scenarios, as I don’t want to throw the baby out with the “sewer water, dirty, x4.”

Describe alternatives you've considered

Doing a Normandy landings-style storming of the many, many, many, many profession descriptions. I need to pack in my fortitude before I step into that file.

Testing

I simply changed the description strings. I will award myself a medal if I manage to bug something by failing to just write between the pretty quotation marks.

Additional context

Consult #71679 for the original issue.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions Scenarios New Scenarios, balancing, bugs with scenarios astyled astyled PR, label is assigned by github actions labels Feb 12, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 12, 2024
data/json/scenarios.json Outdated Show resolved Hide resolved
@Inglonias
Copy link
Contributor

Aside from the pair of minor typos I found, looks great to me!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 12, 2024
@DoctorBoomstick DoctorBoomstick marked this pull request as draft February 13, 2024 06:54
data/json/scenarios.json Outdated Show resolved Hide resolved
data/json/scenarios.json Outdated Show resolved Hide resolved
data/json/starting_missions.json Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 14, 2024
@Tranberry
Copy link

I assumed Crazy Party was more like the 'orchestra playing as the titanic sank' I mean: "we're going to die, lets not waste our last hours".

@RanikOrtega
Copy link
Contributor

I like the more verbose description for Low Profile.

@DoctorBoomstick
Copy link
Contributor Author

@Tranberry, fair observation with the crazy party scenario. I personally never looked at it that way, as if one considers that the evacuation order went out on the 15th, the government folded like a sandwich on the 25th, and game start is approximately the 30th, then it seems like quite the long party time for it to have lasted up until the 30th of the month. Plus, I found it kind of strange how, when it’s implied to have been a party, there’s no mention of how the building went from party mode to, “Oh good lord, everyone’s dead and killing each other.” I personally always thought that a resort would likely make for a good gathering place for evacuation, so personally, I’d just expand the profession pool to only include vacation and staff-related professions. That being said, if we want to preserve the party vibe, I could look at rewriting the description to reflect a final bash gone wrong. Perhaps I could rewrite it as follows: the resort was slated as an evacuation point; evac never came; to raise everybody’s mood while they waited; a blow-out party was arranged; the sound attracted zombies; and, thus, begins the game.
@Fris0uman, thanks for the thoughts over the food-place-related descriptions. I’ll look at changing the mission description to a more food-place-appropriate vibe.

@Tranberry
Copy link

Perhaps I could rewrite it as follows: the resort was slated as an evacuation point; evac never came; to raise everybody’s mood while they waited; a blow-out party was arranged; the sound attracted zombies; and, thus, begins the game.

Sounds good to me 💛

I imagine the resort instead a primary evacuation spot, just was listed as a possible one. The folks gathering and previous guests already at the resort, understanding that evacuation might never really come, decide to throw this party to lift their spirits.

Copy link
Member

@harakka harakka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typography suggestions

data/json/starting_missions.json Outdated Show resolved Hide resolved
data/json/scenarios.json Outdated Show resolved Hide resolved
data/json/scenarios.json Outdated Show resolved Hide resolved
data/json/scenarios.json Outdated Show resolved Hide resolved
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Business had been bad — for some reason, weeks of rioting, an evacuation order, and the sky breaking with alien shadows prompted a downturn in foot traffic, even among Foodplace’s chain restaurants. As an employee, upon evacuation being declared, you disregarded company orders to lock up your outlet and, along with another survivor, opted to close yourselves within the breakroom to recuperate and plan your next move. Will Foodplace's delicious food™ be enough to placate the horde of hungry customers banging at the door?
  • You heard the global, worsening news and saw the nightmare in the cities firsthand — a situation that prompted you to jump from low-rent motel to cheap trailer, trying to outrun the madness. While only you know where you'd planned to go, when you heard the government’s last broadcast and realised 'no help was coming,' you resolved to raise a dejected toast and sink to the bottom of a bottle for as long as you could. What happened in the following days of drunken stupor is an enigma. What you do know, is that it's time to see how much of the world there’s left to return to.
  • You’re not sure who orders takeout when the world’s ending, but that doesn’t matter. Evacuation doesn’t matter. Nothing, indeed, matters, save for safely delivering your precious cargo to its destination: a remote mansion. May Foodperson watch over you, soldier.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

@DoctorBoomstick DoctorBoomstick marked this pull request as ready for review February 18, 2024 13:24
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 18, 2024
@Maleclypse Maleclypse merged commit 9d41514 into CleverRaven:master Feb 20, 2024
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants