Fix mutation examine window crash #71410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
json-styled
Style fixes Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
BasicBuildPassed
Procyonae
added
the
0.H Backport
Procyonae
pushed a commit
to Procyonae/Cataclysm-DDA
that referenced
this pull request
May 20, 2024
* Fix mutation examine window crash Fixes CleverRaven#71237 * Apply suggestions from code review Style fixes Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Maleclypse
added a commit
that referenced
this pull request
May 21, 2024
Procyonae
added
0.H Backported
and removed
0.H Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71237
Summary
Bugfixes "Made GetTrait function return std::nullopt_t in case of mutation_tab_mode::none"
Purpose of change
Fixes #71237
Describe the solution
GetTrait used to access passive vector when tab_mode is not 'active', which leads to a crash, if there are no mutations at all: tab_mode is 'none' and passive vec is empty.
At the same time GetTrait result is always assigned to 'examine_id' which is 'optional<trait_id>. So it seemed convenient to return empty optional in case of 'none' 'tab_mode'. Then calling code can handle it in correct way.
Describe alternatives you've considered
There was a proposition from @RenechCDDA to guard the call site with
!passive.empty()check.Testing
Additional context