Merge pull request #73969 from Procyonae/Backport71410

Backport #71410
CleverRaven · May 21, 2024 · f1c59fb · f1c59fb
2 parents 96fbdb1 + c030a0c
commit f1c59fb
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/mutation_ui.cpp b/src/mutation_ui.cpp
@@ -49,14 +49,14 @@ static const auto shortcut_desc = []( const std::string_view comment, const std:
 
 // needs extensive improvement
 
-static trait_id GetTrait( const std::vector<trait_id> &active,
-                          const std::vector<trait_id> &passive,
-                          int cursor, mutation_tab_mode tab_mode )
+static std::optional<trait_id> GetTrait( const std::vector<trait_id> &active,
+        const std::vector<trait_id> &passive,
+        int cursor, mutation_tab_mode tab_mode )
 {
-    trait_id mut_id;
+    std::optional<trait_id> mut_id;
     if( tab_mode == mutation_tab_mode::active ) {
         mut_id = active[cursor];
-    } else {
+    } else if( tab_mode == mutation_tab_mode::passive ) {
         mut_id = passive[cursor];
     }
     return mut_id;