Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutation examine window crash #71410

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Fix mutation examine window crash #71410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad22eb
Fix mutation examine window crash
gearhand Feb 1, 2024
c00655e
Apply suggestions from code review
gearhand Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/mutation_ui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ static const auto shortcut_desc = []( const std::string_view comment, const std:

// needs extensive improvement

static trait_id GetTrait( const std::vector<trait_id> &active,
const std::vector<trait_id> &passive,
int cursor, mutation_tab_mode tab_mode )
static std::optional<trait_id> GetTrait( const std::vector<trait_id> &active,
const std::vector<trait_id> &passive,
int cursor, mutation_tab_mode tab_mode )
{
trait_id mut_id;
std::optional<trait_id> mut_id;
if( tab_mode == mutation_tab_mode::active ) {
mut_id = active[cursor];
} else {
} else if( tab_mode == mutation_tab_mode::passive ) {
mut_id = passive[cursor];
}
return mut_id;
Expand Down
Loading