Add gun-mounted ammo holders #70858
Add gun-mounted ammo holders #70858
Conversation
github-actions
bot
added
[JSON]
github-actions
bot
added
the
astyled
|
These are working, but I don't know how to make them dump out their items when detached from the gun, so they delete the shells. Once I figure that out I can add all the other varieties and recipes. |
|
Do they have to dump the ammo? Shells can stay inside a shell holder just fine on their own. (Same as any such ammo holder, really.) Can the ammo be transferred to the gunmod when it's detached? (And vice versa: can ammo inside a detached gunmod stay in the gunmod when it's attached?) |
They do. The way mod pockets are set up is that the pocket disappears entirely when you take it off the gun. So either the shells need to come out or they get deleted. |
| "price_postapoc": 50, | ||
| "install_time": "30 s", | ||
| "material": [ "plastic" ], | ||
| "flags": [ "NOT_MAGAZINE", "TARDIS" ], |
There was a problem hiding this comment.
Why does this need TARDIS flag, a magazine well that covers the volume of the shotshell that isn't poking out should suffice 🤔
There was a problem hiding this comment.
Yeah, either the pocket is rigid and takes up the full space even without contents or it's not rigid and every loaded shell increases the size accordingly. From the images I'd expect the latter.
There was a problem hiding this comment.
It doesn't. I had it on there while trying to figure out a way to keep the shells from falling out when a full holder was removed, but it didn't work and I haven't gotten around to fixing it. Note that this PR is marked draft and is not ready for review.
| "flags": [ "NOT_MAGAZINE", "TARDIS" ], | ||
| "symbol": ":", | ||
| "color": "black", | ||
| "location": "loading port", |
There was a problem hiding this comment.
| "location": "loading port", | |
| "location": "rail", |
Stock-mounted versions also exist https://www.midwayusa.com/product/1014560565?pid=668092
There was a problem hiding this comment.
Isn't the rail on the top of the gun? It wouldn't go up there.
Stock mounted versions are planned. This is a draft.
There was a problem hiding this comment.
The "rail" rail is on the side. It's where non-underbarrel laser sights go. (There are also underbarrel and top rails, which are referred to in-game as "underbarrel" and "sights" locations.)
On pump-action (and modern automatic) shotguns, the side rail would likely be on the forend (the thing you "pump" after each shot, the thing that goes chuck-chuck). This isn't an adequate position for a shell holder, since a filled holder would interfere with one's ability to grip the forend. See this replacement forend with an underbarrel rail and two side rails:
https://trinitysupply.com/cdn/shop/files/2_042cc13a-522b-42f6-9c74-c1022d30baed.jpg
But since we don't have a "body" location or something, rails would do.
There was a problem hiding this comment.
I don't see any that fit on the forend, but I see a bunch that straddle the receiver and add a top rail to the gun. Not sure how we'd represent that.
There was a problem hiding this comment.
I guess there are these, but this doesn't look like something that would fit on any old gun. I think my PR will just add generally-applicable mods and I'll leave the hyper-specifics to others.
There was a problem hiding this comment.
They don't necessarily go over the top. Looks like they're mostly held by the pins(?) on the shotgun's body, as can be seen in the (poor-quality, but legible) instructions on this product:
https://www.amazon.com/TacStar-6-Shot-Sidesaddle-Black/dp/B001AMZXQI
Which, again, might require a special slot on shotguns, which may or may not be beyond this PR's scope.
github-actions
bot
added
<Bugfix>
|
I'd like to bring up the existence of magazine pouches for the stock. To hold magazines or stripper clips. Here's an older example.
But there's also more modern variants for the M4/M15/M16. Fits regular and collapsible stocks. Holds 1 magazine. Here's a video of one being attached. Don't quite have the time to check how it looks for other calibers/mag types on other guns in detail. But there's also a 2 Mag capacity (10 rounds) for the mini-14. |
|
Mag pouches are a good idea. I also want to do bandolier straps, but it's all waiting on a fix for #70925 |
|
There's an issue I ran into when adding the Steyr Scout and its hollow stock, selecting two magazines to fit into the stock caused an error. Everything worked perfectly besides that, it still refused to slot two in. Speaking of, you may want to look into the Scout's hollow stock to adjust its stats since you're more familiar with the code, especially now, than me. |
|
Inactive for 7 months. |
Summary
Features "Adds mods for guns, rifles, and bows that create a pocket for extra ammo"
Purpose of change
IRL there are little doodads you can strap to your gun that hold a few shells or cartridges for quick reloading. There are also bow-mounted quivers. Given that reload speed is a major factor for weapons that reload one round at a time, it would be useful to have these in the game.
closes #69943
Describe the solution
Adds a few mods with a pocket that hold a the appropriate ammo type and can be fitted to the weapon. These will have a base item retrieval speed of 25 moves, putting them on par with the shell loops on a tac vest.
Describe alternatives you've considered
None yet.
Testing
WIP
Additional context