Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell Holders #69943

Closed
worm-girl opened this issue Dec 3, 2023 · 5 comments
Closed

Shell Holders #69943

worm-girl opened this issue Dec 3, 2023 · 5 comments
Labels
stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@worm-girl
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Long guns, especially shotguns, can IRL be fitted with mods like you see here:

image

These would be tremendously useful in Cataclysm, as similar to the shell holders on the tac vest, they could have a low item retrieval time (the tac vest's shell loops are 25 moves), making shotguns much faster to reload.

Solution you would like.

I attempted to add these myself, but while the mod worked as a pocket when it was apart from the gun, once I installed it, its pocket became inaccessible. I can't quite figure out how to make it work. Here's what I tried:

{
  "id": "12_gauge_shell_holder",
  "type": "GUNMOD",
  "name": {
    "str": "12 gauge shell holder"
  },
  "description": "Designed to be affixed to the side of a shotgun's receiver, this polymer shotshell holder can store six 12 gauge shells for easy reloading.",
  "weight": "16 g",
  "volume": "60 ml",
  "price": 2000,
  "price_postapoc": 50,
  "install_time": "30 s",
  "material": [
    "plastic"
  ],
  "symbol": ":",
  "color": "black",
  "location": "loading port",
  "mod_targets": [
    "shotgun"
  ],
  "pocket_data": [
    { "pocket_type": "CONTAINER", "rigid": true, "max_contains_volume": "1 L", "max_contains_weight": "3 kg" },
    {
      "ammo_restriction": {
        "shot": 6
      },
      "moves": 25
    }
  ],
  "min_skills": [
    [
      "weapon",
      1
    ]
  ]
}

If anyone knows how to make this function properly, it'd be a really nice item to have.

Describe alternatives you have considered.

Using a mag-fed shotgun to kill zombies (heresy).

Additional context

No response

@worm-girl worm-girl added the <Suggestion / Discussion> Talk it out before implementing label Dec 3, 2023
@GuardianDll
Copy link
Member

Test this json in the recent experimental, it supposed to work now, after #69828 was merged

@worm-girl
Copy link
Contributor Author

Test this json in the recent experimental, it supposed to work now, after #69828 was merged

image

Just tried it, doesn't seem to work. I don't see a pocket anywhere on the item, I can't open it, I can't access the holder at all without removing it.

@mqrause
Copy link
Contributor

mqrause commented Dec 11, 2023

You would need to use pocket_mods instead of pocket_data, then it might just work.

@worm-girl
Copy link
Contributor Author

You would need to use pocket_mods instead of pocket_data, then it might just work.

Thanks, I'll give that a shot.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants