-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pocket_mods to add magazine or magazine well pockets to items without them #69828
Conversation
d6b3ecb
to
a17eca9
Compare
a17eca9
to
20cbe4e
Compare
20cbe4e
to
5931cfd
Compare
5931cfd
to
79ba67e
Compare
btw, what will happen if item has one pocket, but one try to add another one? is there a way to specify "this one should overwrite pocket, and that one add another pocket"? |
Container pockets can only be added currently, magazine/magazine well pockets only overridden. |
That is better than i expected, thanks |
I guess I should have added documentation for this, too. |
I'll doing it already |
Summary
Bugfixes "Allow pocket_mods to add magazine or magazine well pockets to items without them"
Purpose of change
#69725 throws a ton of errors because gunmods could only alter magazine wells, but not add them.
Describe the solution
pocket_type
enum to it's own header #69794pocket_data::operator==
also compares various restrictionsDescribe alternatives you've considered
Testing
The new test passes.
Additional context