Gunmod test

[reddragon7799]

Summary

Content "Added more gunmods"

Purpose of change

I like the current gunmod system, but I think it would benefit from having more options. I also found it strange that the Mauser C96 was added to the game but no mention was made of its combination stock/holster, which seems like just the kind of thing that a light-traveling survivor would appreciate; the Chinese soldiers of the warlord period certainly did!

Describe the solution

Added nine two new gunmods, along with crafting recipes for most one of them.

Describe alternatives you've considered

Not add them? I suppose I could have completely reworked the existing system, but that's a little outside of my wheelhouse

Testing

Checked to see if the items I added appeared in the debug menu and, when spawned in, functioned as expected. For those with crafting recipes, I also made sure they were craftable.

Additional context

This is really a small selection of the kind of stuff people put on/in their guns, but I wanted to keep the scope limited to the most common accessories not already in the game (although I'd love to add tactical picatinny cupholders eventually). Currently the utility of the mods that hold extra ammunition is somewhat limited because you can't see what's inside of them once they've been attached to the gun, but I have no idea how to fix that.

[TheShadowFerret]

Currently the utility of the mods that hold extra ammunition is somewhat limited because you can't see what's inside of them once they've been attached to the gun, but I have no idea how to fix that.

This did kill the previous attempt( #70858) 🤔

[osuphobia]

For the ammo carriers/ mag pouches, did you actually test whether you can reload your gun with ammo/magazine inside them?

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• buttstock ammunition clipss
• buttstock ammunition loopss
• speedload shotgun stock
• speedload shotgun stocks

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[reddragon7799]

For the ammo carriers/ mag pouches, did you actually test whether you can reload your gun with ammo/magazine inside them?

So, embarrassingly, I forgot to! The C96 stock works as intended though, and you can attach it to the pistol while the pistol is in the stock without having to manually take it out. I wasn't aware of the earlier attempt but it makes sense that I wasn't the first to think of this... I suppose we will have to wait for the code to let us add ammo loops and flashlight holders and whatnot. There are still some parts of the work I did that don't rely on storage gimmicks and I would like to see if I can get those in.

[reddragon7799]

Hello! Bumping this because I think it's ready to merge (all required checks passed).