fix weapon steadiness bar not working #70060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# |<-- Using around 50, Maximum 72 Characters -->| due to a bug the bar only shows up when steadiness is full, problem was that the calculated steadiness was stored in an int while the value was a double resulting in either empty or full bar. # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567 fixes CleverRaven#69954
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix weapon steadiness bar not working
Summary
Bugfixes "fix weapon steadiness bar not working"
Purpose of change
Due to a bug the bar only shows up when steadiness is full. Fixes #69954.
Describe the solution
Problem was that the calculated steadiness to display was wrongly stored in an int while the calculated value was a double resulting in either empty (0) or full bar (1).
Describe alternatives you've considered
I actually thought that the problem would be way harder to solve
Testing
I created a default world spawned myself a gun and now steadiness fills up correctly
Additional context