Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weapon steadiness bar doesn't display partial steadiness, only empty or full #69954

Closed
CoroNaut opened this issue Dec 3, 2023 · 1 comment · Fixed by #70060
Closed

Weapon steadiness bar doesn't display partial steadiness, only empty or full #69954

CoroNaut opened this issue Dec 3, 2023 · 1 comment · Fixed by #70060
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@CoroNaut
Copy link

CoroNaut commented Dec 3, 2023 •
edited
Loading

Describe the bug

The weapon steadiness bar should probably display any amount of steadiness.

Attach save file

testing3-trimmed.tar.gz

Steps to reproduce

  1. Get weapon
  2. Steady weapon and notice that steadiness either displays 0% or 100% when fully aimed

Expected behavior

Weapon steadiness bar displays partial steadiness

Screenshots

First picture shows 0% actual steadiness, second picture is 99% actual steadiness, third picture is 100% actual steadiness
image
image
image

Versions and configuration

  • OS: Windows
    • OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
  • Game Version: 5d3940a [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Slowdown Fungal Growth [no_fungal_growth]
    ]

Additional context

No response
@CoroNaut CoroNaut added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Dec 3, 2023
@OldFriendEr
Copy link
Contributor

was bugging me for a while, working on it now

OldFriendEr added a commit to OldFriendEr/Cataclysm-DDA that referenced this issue Dec 7, 2023
@OldFriendEr
fix weapon steadiness bar not working
3bb14d7 
# |<-- Using around 50, Maximum 72 Characters -->|

due to a bug the bar only shows up when steadiness is full, problem was
that the calculated steadiness was stored in an int while the value was
a double resulting in either empty or full bar.
# |<----      Limit Each Line to a Maximum Of 72 Characters       ---->|

# Provide links or keys to any relevant tickets, articles or other resources
# Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567
fixes CleverRaven#69954
@OldFriendEr OldFriendEr mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix weapon steadiness bar not working OldFriendEr/Cataclysm-DDA
2 participants
@OldFriendEr @CoroNaut