DEBUG: overmap::remove_npc: NPC (1) is not dead. #1234

jkaessens · 2013-05-26T14:06:41Z

Lure a monster near the evac shelter, let the NPC do the work and hope it dies.
The moment the NPC gets the last strike, the above message appears. Next turn, the NPC is gone, probably not as dead as it should be, as no corpse is left.

Version: changelog-205-ga62858a
Last commit: a62858a
Reproducible: randomly. seems only to happen if several zeds are hitting the NPC at the same time.

The text was updated successfully, but these errors were encountered:

kevingranade · 2014-09-01T09:59:10Z

Think this got handled with one of the death cleanup cleanups, please reopen or open a new one if it happens again.

# |<-- Using around 50, Maximum 72 Characters -->| Allow character to see an opaque tile while standing on another adjacent opaque tile. # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567 Fixes CleverRaven#28694

fix some monster description typos # Explain why this change is being made grammatical reasons # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

fix some monster description typos # Explain why this change is being made grammatical reasons # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes #1234, closes #2345, resolves #3456, references #4567

Hammering 1 requirement for picking up frozen liquids # Explain why this change is being made Player can't scoop up solid ice with their hands, need something to chip off chunks with # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

# |<-- Using around 50, Maximum 72 Characters -->| Adds freeze dryer. Adds dehydrated royal jelly. Spoilage for Royal Jelly # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| Works toward resolving CleverRaven#41361 # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

# |<-- Using around 50, Maximum 72 Characters -->| # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

#### Summary None  #### Purpose of change It makes the cost and material content of the wolf and dino suit more closely inline with reality. It bugged me that the wolf suit didn't have any cotton in it, and that the prices seemed a bit too high for what a fursuit is.  #### Describe the solution It changes the wolf suit materials to include faux fur and cotton, and changes the cost of both of them to a more realistic amount.  #### Testing I loaded the game up with the settings changed, and it worked without any bugs.  #### Additional context https://cdn.discordapp.com/attachments/638239225803702283/880617361995083796/unknown.png Screenshot of the wolf suit.

# Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

# |<-- Using around 50, Maximum 72 Characters -->| # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

# |<-- Using around 50, Maximum 72 Characters -->| armor part breathability will be calculated if override has invalid value set # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

* Flight gear * Update data/json/items/tool_armor.json Co-authored-by: Binrui Dong <[email protected]> * Update data/json/items/tool_armor.json Co-authored-by: Anton Burmistrov <[email protected]> * Update data/json/items/tool_armor.json Co-authored-by: chaohedgehogs <[email protected]> * Update data/json/items/tool_armor.json Co-authored-by: chaohedgehogs <[email protected]> * Update data/json/items/tool_armor.json Co-authored-by: Binrui Dong <[email protected]> * Update tool_armor.json Added Two-Way Radio to the helmet when on, in-built radio was a common functionality with the helmets I researched. * Update 9mm.json 9x19mm +P+ is about double the price of 9x19mm +P as per my cursory research. * Update suits_protection.json * Update tool_armor.json * Update 9mm.json * Revert "9x19mm +P and + prices" (#49155) * enable to override armor breathability using JSON The breathability currently is being calculated by the least breathable material, in some cases it contradicts the item description in this case the nomad_bodyglove_1, witch is breathable, but has breathability 0 due to some rubber in it. Now it can be set from JSON file. I also adjusted the nomad_bodyglove_1 breathability values by using material breathability of lycra and cotton. * Update src/itype.h Co-authored-by: haveric <[email protected]> * will handle breathability override invalid values # |<-- Using around 50, Maximum 72 Characters -->| armor part breathability will be calculated if override has invalid value set # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes #1234, closes #2345, resolves #3456, references #4567 * breathability override no uses enum # |<-- Using around 50, Maximum 72 Characters -->| had a suggestion not to use arbitrary values but use defined enums # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| * Update src/material.h Co-authored-by: Dillon Matchett <[email protected]> * linted JSON custom_underwear.json was not linted, now its good Co-authored-by: faefux <[email protected]> Co-authored-by: fae <[email protected]> Co-authored-by: Binrui Dong <[email protected]> Co-authored-by: Anton Burmistrov <[email protected]> Co-authored-by: chaohedgehogs <[email protected]> Co-authored-by: Angela Graves <[email protected]> Co-authored-by: eso <[email protected]> Co-authored-by: haveric <[email protected]> Co-authored-by: Dillon Matchett <[email protected]>

* Medical Menu Implementation Implements the initial steps for the Medical Menu, changes including; ~keybindings.json - Adds 'View Medical' hotkey under 'N' ~action.cpp / ~action.h / ~avatar.h / handle_action.cpp / game.cpp - Adds the corresponding action to 'View Medical' +medical_ui.cpp - Menu implementation ~display.h / display.cpp - Exposes bodypart_status_colors * [Medical Menu] Basic Build and Test (GCC 9, Curses, LTO) Styling Removal of a couple variables left behind from previous implementation, correct character casting. * [Medical Menu] Extended Implementation -Access from Player Info ('@') Menu -Info Menu -Scrolling Text -Formatting -Astyle & Clang Tidy * [Medical Menu] Removal of widget dependency Removed temporarily until the widget implementation is less in-progress; Code cleanup. * Update data/raw/keybindings.json * Refactoring # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes #1234, closes #2345, resolves #3456, references #4567 * [Medical Menu] Code Clarity # |<-- Using around 50, Maximum 72 Characters -->| # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes #1234, closes #2345, resolves #3456, references #4567 * [Medical Menu] C++ Analysis # |<-- Using around 50, Maximum 72 Characters -->| # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes #1234, closes #2345, resolves #3456, references #4567 * Update src/medical_ui.cpp * [Medical Menu] Static efftype_id # |<-- Using around 50, Maximum 72 Characters -->| # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes #1234, closes #2345, resolves #3456, references #4567 Co-authored-by: Maleclypse <[email protected]> Co-authored-by: Kevin Granade <[email protected]>

# |<-- Using around 50, Maximum 72 Characters -->| those two particular samples were missing in the loot-table # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| closes CleverRaven#58255 # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

# |<-- Using around 50, Maximum 72 Characters -->| those two particular samples were missing in the loot-table # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| closes #58255 # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes #1234, closes #2345, resolves #3456, references #4567

# |<-- Using around 50, Maximum 72 Characters -->| those two particular samples were missing in the loot-table # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| closes CleverRaven#58255 # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

#### Summary Features "Added an option to toggle between drug brand names and generic functional names"  #### Purpose of change CleverRaven#51689 Added this option for players who prefered the older version of the game. which had brand names.  #### Describe the solution Added a variant to the med.json adding brand names to item desciptions and use actions. item.cpp, options.cpp, and item.h adds functionality for a toggle like the "show gun brand" option  #### Describe alternatives you've considered  #### Testing Ran it until I found prescription stimulants and toggled the button to ensure it worked. (Should display adderall brand name in description)  #### Additional context

# Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| There was some clang compilation errors and misspeling in previous commits # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567

#### Summary None  #### Purpose of change Fix issues in README on the main page  #### Describe the solution Fix link and update links to https while at it  #### Describe alternatives you've considered Update the .github link to be interacive somehow (but it doesn't work on browser for some reason)  #### Testing Clicking the link which brings to CONTRIBUTION directly  #### Additional context None

#### Summary None  #### Purpose of change Fix issues in README on the main page  #### Describe the solution Fix link and update links to https while at it  #### Describe alternatives you've considered Update the .github link to be interacive somehow (but it doesn't work on browser for some reason)  #### Testing Clicking the link which brings to CONTRIBUTION directly  #### Additional context None

Don't allow to scan books that are owned by other character # Explain why this change is being made # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| It was possible to scan books from merchant inventory without buying them. # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567 fixes CleverRaven#65840

# |<-- Using around 50, Maximum 72 Characters -->| due to a bug the bar only shows up when steadiness is full, problem was that the calculated steadiness was stored in an int while the value was a double resulting in either empty or full bar. # |<---- Limit Each Line to a Maximum Of 72 Characters ---->| # Provide links or keys to any relevant tickets, articles or other resources # Example: fixes CleverRaven#1234, closes CleverRaven#2345, resolves CleverRaven#3456, references CleverRaven#4567 fixes CleverRaven#69954

#### Summary Content "Adds a new Special, Oil Platforms, to spawn in the ocean."  #### Purpose of change The ocean is completely devoid of content right now, and I understand it might make it very unappealing to work on before anything is actually there to make people interested in going there, so I figured I'd get the machine rolling while trying my hands at doing some mapping for CDDA !  #### Describe the solution This special is UNIQUE with a 5% chance of spawning per overmap, I tried using check_for_locations to prevent it from spawning to close to the short with no luck, so city_distance is what's kind of doing that for now. It features mostly industrial loot (Tools, electronics, work/diving clothes, heavy machinery, solar pannels), as well as quite a few skill books, medicine, food, some chemistry ingredients, and the potential for 55gal drums containing various fuel, as well as newly added crude oil (which I'd like to make a recipe to turn into fuel with a catalytic cracking reactor in the future). There's a 20% chance for a helicopter spawn on the helipad, which might be a wreck (from the "helicopters" spawn group), and four 10% chance for single motor boat spawns by the pillars on the water. There's also up to three inflatable boats floating down below the emergency dockings on the east side. Besides the most common types of zombies, It is mostly populated by zombie/feral mechanics or crewmen, swimmer zombies, and there are small chances of zapper/gasoline zombies to spawn. For the latter, there are four hardcoded locations with 5% chance of spawning, and some further chances in the zombie group a week in. Figured it'd work well thematically and could be interesting as either a boon or a bane depending on how you handle it. I tried to stick as best as I could to what an oil platform could look like by doing quite a bit of research, the only thing I really skirted around was for the plume; a chimney that usually extends quite a ways out over the ocean to burn excess gas. I didn't want there to be somewhere you could just easily walk to and attract all the zombies to take a dive so easily, so it mostly goes up in height. I went with a gravity based structure, the supporting pillars extending all the way to the bottom of the ocean, because I'd like, in a potential follow up, leave some room to add a small chance of it having a submerged hidden lab kind of thing in the concrete slab at the bottom. Such pillars usually are used to house piping that'd connect to underwater pipe-lines, so I figured it'd be good like this for now anyways ! Plus it makes it easier to justify every bit of piping that runs along the platform, which i've tried to do as best as possible.  #### Describe alternatives you've considered - As said above, adding a chance for a hidden submerged lab to be connected to the pillars going down - probably for a new project if it seems like a good idea. - Adding ramps instead of stairs to the various walkways - seemed like idle zombies liked to kill themselves by walking up and dropping back down. - Making it bigger and globally_unique, but I'd rather have both if possible ! - Adding even more chances for gasoline zombies to spawn as time progresses.  #### Testing Spawning in a new world, teleporting to the ocean, seems to spawn fine. Going around to see if I've made any mistakes, fixed all the ones I could see.  #### Additional context Screenshots : (I'm not sure if this'll work but I'll try) <blockquote class="imgur-embed-pub" lang="en" data-id="a/PHeXLWv" data-context="false" ><a href="//imgur.com/a/PHeXLWv"></a></blockquote><script async src="//s.imgur.com/min/embed.js" charset="utf-8"></script>

* Adds Oil Platform specials to spawn in the ocean  #### Summary Content "Adds a new Special, Oil Platforms, to spawn in the ocean."  #### Purpose of change The ocean is completely devoid of content right now, and I understand it might make it very unappealing to work on before anything is actually there to make people interested in going there, so I figured I'd get the machine rolling while trying my hands at doing some mapping for CDDA !  #### Describe the solution This special is UNIQUE with a 5% chance of spawning per overmap, I tried using check_for_locations to prevent it from spawning to close to the short with no luck, so city_distance is what's kind of doing that for now. It features mostly industrial loot (Tools, electronics, work/diving clothes, heavy machinery, solar pannels), as well as quite a few skill books, medicine, food, some chemistry ingredients, and the potential for 55gal drums containing various fuel, as well as newly added crude oil (which I'd like to make a recipe to turn into fuel with a catalytic cracking reactor in the future). There's a 20% chance for a helicopter spawn on the helipad, which might be a wreck (from the "helicopters" spawn group), and four 10% chance for single motor boat spawns by the pillars on the water. There's also up to three inflatable boats floating down below the emergency dockings on the east side. Besides the most common types of zombies, It is mostly populated by zombie/feral mechanics or crewmen, swimmer zombies, and there are small chances of zapper/gasoline zombies to spawn. For the latter, there are four hardcoded locations with 5% chance of spawning, and some further chances in the zombie group a week in. Figured it'd work well thematically and could be interesting as either a boon or a bane depending on how you handle it. I tried to stick as best as I could to what an oil platform could look like by doing quite a bit of research, the only thing I really skirted around was for the plume; a chimney that usually extends quite a ways out over the ocean to burn excess gas. I didn't want there to be somewhere you could just easily walk to and attract all the zombies to take a dive so easily, so it mostly goes up in height. I went with a gravity based structure, the supporting pillars extending all the way to the bottom of the ocean, because I'd like, in a potential follow up, leave some room to add a small chance of it having a submerged hidden lab kind of thing in the concrete slab at the bottom. Such pillars usually are used to house piping that'd connect to underwater pipe-lines, so I figured it'd be good like this for now anyways ! Plus it makes it easier to justify every bit of piping that runs along the platform, which i've tried to do as best as possible.  #### Describe alternatives you've considered - As said above, adding a chance for a hidden submerged lab to be connected to the pillars going down - probably for a new project if it seems like a good idea. - Adding ramps instead of stairs to the various walkways - seemed like idle zombies liked to kill themselves by walking up and dropping back down. - Making it bigger and globally_unique, but I'd rather have both if possible ! - Adding even more chances for gasoline zombies to spawn as time progresses.  #### Testing Spawning in a new world, teleporting to the ocean, seems to spawn fine. Going around to see if I've made any mistakes, fixed all the ones I could see.  #### Additional context Screenshots : (I'm not sure if this'll work but I'll try) <blockquote class="imgur-embed-pub" lang="en" data-id="a/PHeXLWv" data-context="false" ><a href="//imgur.com/a/PHeXLWv"></a></blockquote><script async src="//s.imgur.com/min/embed.js" charset="utf-8"></script>   * Of course I spot a mistake right after I create the PR * Update data/json/furniture_and_terrain/terrain-manufactured.json * Update data/json/furniture_and_terrain/terrain-manufactured.json * Fixed wrong surface water type, a wrongly aligned pipe, and made the platform a little longer to avoid zombies spawning outside of its berth * Added a catalytic cracking reactor, reworked the drum groups to make more sense where they spawn * Fixed crude_oil's material and ammo type, removed processed fuel and the rope leading to the crane, replaced forklifts by trolleys, increased minimum city distance and liquid amount in containers * Fixed crude_oil's material and ammo type, removed processed fuel and the rope leading to the crane, replaced forklifts by trolleys, increased minimum city distance and liquid amount in containers * Accidentally modified the crude lamp oil energy value, this should fix it (Sorry, struggling a little with github here) * Update data/json/mapgen/oil_platform/oil_platform_z2.json * Update data/json/furniture_and_terrain/terrain-manufactured.json * Update data/json/mapgen/oil_platform/oil_platform_z2.json * Apply suggestions from code review * Switched the tanks leading to the generators from salt water to diesel (didn't make sense) * Update overmap_terrain_coverage_whitelist.json * Update data/json/items/fuel.json --------- Co-authored-by: Maleclypse <[email protected]>

Abalieno mentioned this issue Nov 23, 2013

Tile mode needs refactoring #4236

Closed

kevingranade closed this as completed Sep 1, 2014

Maleclypse mentioned this issue Feb 28, 2021

[Magiclysm] Remove elf spawn in forge #47798

Merged

JumiDeluxe mentioned this issue Mar 29, 2022

Fix fleeting zombie pigs JumiDeluxe/Cataclysm-DDA#1

Merged

PatrikLundell mentioned this issue Nov 5, 2023

elaborate on PRs closing issues, comments for cc #69118

Merged

Holli-Git mentioned this issue May 25, 2024

Civilianize the SIG 553 #74085

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEBUG: overmap::remove_npc: NPC (1) is not dead. #1234

DEBUG: overmap::remove_npc: NPC (1) is not dead. #1234

jkaessens commented May 26, 2013

kevingranade commented Sep 1, 2014

DEBUG: overmap::remove_npc: NPC (1) is not dead. #1234

DEBUG: overmap::remove_npc: NPC (1) is not dead. #1234

Comments

jkaessens commented May 26, 2013

kevingranade commented Sep 1, 2014