Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magiclysm: Frost armor actually works now #65038

Closed
wants to merge 1 commit into from
Closed

Magiclysm: Frost armor actually works now #65038

wants to merge 1 commit into from

Conversation

Saint-of-Grey
Copy link
Contributor

Summary

Bugfixes "Magiclysm: Made frost armor actually do something"

Purpose of change

I noticed that casting the frost armor spell would summon "0 frost armors". And indeed, when successfully cast, it eats your mana and does nothing. So I fixed that real quick.

Describe the solution

Added a missing "min_damage" : 1 and "max_damage": 1 to the frost armor spell and the upgraded version.

Describe alternatives you've considered

Ending all my kelvinist runs by crying myself to sleep.

Testing

Fired up a game, cast the spell, now it works.

Additional context

As far as I know, this wasn't reported, and I figured fixing it was just as much effort as writing a bug report for it.

@Saint-of-Grey Saint-of-Grey requested a review from KorGgenT as a code owner April 12, 2023 23:33
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mechanics: Enchantments / Spells Enchantments and spells Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod <Bugfix> This is a fix for a bug (or closes open issue) labels Apr 12, 2023
@casswedson
Copy link
Contributor

#64989 and #64965 both address this

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 12, 2023
@Saint-of-Grey
Copy link
Contributor Author

So there's an underlying issue? That explains why I couldn't find anything about it specifically.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saint-of-Grey @casswedson