Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternative fix: item spawning spells with no min/max damage #64989

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Apr 10, 2023

Summary

None

Purpose of change

Alternative to #64965, recreates the old behavior so it doesn't break existing json.

Describe the solution

Always spawn at least one item/item group, even with no damage defined.

Describe alternatives you've considered

Testing

Additional context

@casswedson probably of interest to you. I can't judge what the actually preferable solution would be since I don't know too much about spells.

@mqrause mqrause requested a review from KorGgenT as a code owner April 10, 2023 23:03
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Enchantments / Spells Enchantments and spells json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 10, 2023
@dseguin dseguin merged commit 9b32c0d into CleverRaven:master Apr 14, 2023
@mqrause mqrause deleted the spell_spawn_fix branch April 15, 2023 00:29
@casswedson
Copy link
Contributor

I created a new character and gave myself a level 4 repelling arc; it's not doing the thing
Screenshot from 2023-04-16 17-03-52

  • OS: Linux
    • OS Version: Distributor ID: Pop; Description: Pop!_OS 22.04 LTS; Release: 22.04; Codename: jammy;
  • Game Version: afda5f6 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions],
    Magiclysm [magiclysm]
    ]

@mqrause
Copy link
Contributor Author

mqrause commented Apr 16, 2023

I'm pretty sure that's just a UI bug. And I'm also actually fairly sure it's been like that before? Or it wasn't actually my fault and someone changed spell damage calculations.

@casswedson
Copy link
Contributor

the only thing I can say is that the spell does not work, if I cast it does not spawn anything

@mqrause
Copy link
Contributor Author

mqrause commented Apr 16, 2023

Oh god, yeah, I see my stupid mistake. Using std::min instead of std::max. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants