Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: item spawning spells with no min/max damage #64965

Closed

Conversation

casswedson
Copy link
Contributor

Summary

None

Purpose of change

if a spell with the effect spawn_item does not have a defined min/max damage it will not spawn anything at any level (given it doesn't have something like damage increment)

setting the values manually just makes sense, just in case, so it always spawns something at level 1

scraped a bunch of data in search of spells that spawn items and do not have min/max damage defined, there were some

purpose of change:
how dare you make my favorite spell repelling arc useless as it does not spawn anything >:(

Describe the solution

Describe alternatives you've considered

Testing

Additional context

if a spell with the effect `spawn_item` does not have a defined min/max
damage it will not spawn anything at any level (given it doesn't have
something like damage increment)

setting the values manually just makes sense, just in case, so it always
spawns something at level 1

scraped a bunch of data in search of spells that spawn items and do not
have min/max damage defined, there were some

purpose of change:
how _dare_ you make my favorite spell repelling arc useless as it does not
spawn anything >:(
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Mechanics: Enchantments / Spells Enchantments and spells Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Xedra Evolved Anything to do with Xedra Evolved json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 9, 2023
@mqrause
Copy link
Contributor

mqrause commented Apr 9, 2023

how dare you make my favorite spell repelling arc useless as it does not spawn anything >:(

Oops, that's an unintended side effect of #64600. Instead of adding damage to all spells a small fix for this loop might be the better solution.

for( int i = 0; i < sp.damage( caster ); i++ ) {

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 10, 2023
@casswedson casswedson closed this Apr 14, 2023
@casswedson casswedson deleted the please-spawn-something branch April 14, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Aftershock Anything to do with the Aftershock mod Mods: Magiclysm Anything to do with the Magiclysm mod Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants