Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag heavier vehicles take 2 #64867

Merged

Conversation

anoobindisguise
Copy link
Contributor

@anoobindisguise anoobindisguise commented Apr 5, 2023

Summary

Balance "player can drag heavier vehicles"

Purpose of change

Continue work on #63737

Describe the solution

Changes from the first PR:

  • The strength requirement to drag a vehicle off road is now adjusted by the vehicle's off roading capability. This may mean a shopping cart will just get stuck if dragged onto grass.
  • There is a strong stamina cost associated with moving a vehicle, given an athletic human has about 10k stamina, and are dragging a vehicle that has an appropriate weight for your strength, you can drag a vehicle for about 2 minutes straight. This could be increased further to a higher amount of stamina cost.
  • Time to drag a heavy vehicle increases a lot. At a matching str requirement and your strength, you drag a thing about 20% of your normal speed.
  • Removed the max strength limit as it is unnecessary, your own strength will set limits for this naturally. Either it does nothing because you weren't strong enough for it to matter anyways or it artificially prevents you from dragging something you are strong enough to drag.

Describe alternatives you've considered

  • Higher stamina cost.
  • More qualifiers to reduce your ability to drag stuff.

Testing

Tried an 8 strength character dragging two different vehicles. Shopping cart (empty) and car (about 1000kg).
Shopping cart is slower than walking but it's not really tiring. Dragging it offroad makes it super slow but not strenuous.
Dragging a car is possible but very slow, exhausting, and often a little bit painful. It gets even slower off road but is still barely draggable, unless you get it into some bad terrain (such as a patch of tall grass) in which case it can get totally stuck.
Spawned a wrecked car with no wheels and couldn't drag it at all.
The character was unable at all to drag a vehicle that was much heavier (1500kg 4x4 car) but upon boosting strength to 20 it became easy and wasn't any more difficult offroad.

Additional context

@kevingranade

@anoobindisguise anoobindisguise marked this pull request as draft April 5, 2023 19:37
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 5, 2023
@worm-girl
Copy link
Contributor

Just giving a quick heads up to make sure that a travois works on grass after this change, as that is the purpose of a travois.

I cannot wait to see people going bovine just so they can be an ox and pull their own cart!

@anoobindisguise
Copy link
Contributor Author

Just giving a quick heads up to make sure that a travois works on grass after this change, as that is the purpose of a travois.

I cannot wait to see people going bovine just so they can be an ox and pull their own cart!

Travois might need to be changed into some kind of hybrid storage/wheel with off road capabilities yea

@chrispikula
Copy link
Contributor

Travois might need to be changed into some kind of hybrid storage/wheel with off road capabilities yea

Maybe a 'wear-resistant support lever' wheel type object? Not sure what the best term to describe it should be.

It should also get damaged in use and when overloaded, but that's a ways off and beyond the scope of this PR. Part of me is now also imagining that if it becomes a wheel, that somehow there's going to be a bug with people re-inflating it.

@Sirbab
Copy link
Contributor

Sirbab commented Apr 14, 2023

Not being able to push a small car like a hatchback has really weirded me out. I'm not very fit and I can pop my car into neutral and push it at slow speed, probably like 0.25-0.5mph. Especially when you need to clear a road the the vehicles don't have broken wheels/tires. At least on asphalt, and not going uphill.

@anoobindisguise anoobindisguise marked this pull request as ready for review May 10, 2023 19:58
@bombasticSlacks bombasticSlacks merged commit 0bc9651 into CleverRaven:master May 18, 2023
@anoobindisguise anoobindisguise deleted the anoobindisguise-grab-veh-2 branch June 7, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants