Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drag heavier vehicles #2840

Merged
merged 5 commits into from
May 20, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented May 19, 2023

Summary

Balance "player can drag heavier vehicles"

Purpose of change

port CleverRaven/Cataclysm-DDA#64867 by @anoobindisguise

Describe the solution

  1. ported line changes.
  2. extracted calculation functions from grabbed_veh_move.

Testing

2023-05-19.09-35-20.mp4

@github-actions github-actions bot added the src changes related to source code. label May 19, 2023
@scarf005 scarf005 force-pushed the drag-heavy-vehicle branch 2 times, most recently from 59954c3 to 04dab43 Compare May 19, 2023 01:59
src/grab.cpp Outdated Show resolved Hide resolved
@scarf005 scarf005 force-pushed the drag-heavy-vehicle branch from 04dab43 to db9da4f Compare May 19, 2023 02:01
@scarf005 scarf005 force-pushed the drag-heavy-vehicle branch from db9da4f to 72529de Compare May 19, 2023 02:05
@chaosvolt
Copy link
Member

chaosvolt commented May 19, 2023

Removed the max strength limit as it is unnecessary

Nice, that was the number one aspect I would've been inclined to grab.

@scarf005 scarf005 requested review from Firestorm01X2 and chaosvolt and removed request for Firestorm01X2 May 20, 2023 05:04
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Compiled and load-tested.
  2. Spawned in a car, can push it around with 8 strength but sometimes takes time or strains.
  3. Took parts off until weight was under 800 kg, it moves without straining, only sometimes taking extra time.
  4. Increased strength to 9, no more "takes time" messages showed up.
  5. Summoned a semi truck, can't even try to shove it at 9 strength.
  6. Increased strength to 70, can indeed move it.

image

Side note, vehicle pushing is just amazingly janky when you're trying to turn it around, but this is unrelated to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants