-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drag heavier vehicles #2840
Merged
chaosvolt
merged 5 commits into
cataclysmbnteam:upload
from
scarf005:drag-heavy-vehicle
May 20, 2023
Merged
feat: drag heavier vehicles #2840
chaosvolt
merged 5 commits into
cataclysmbnteam:upload
from
scarf005:drag-heavy-vehicle
May 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: anoobindisguise <[email protected]>
scarf005
force-pushed
the
drag-heavy-vehicle
branch
2 times, most recently
from
May 19, 2023 01:59
59954c3
to
04dab43
Compare
scarf005
force-pushed
the
drag-heavy-vehicle
branch
from
May 19, 2023 02:01
04dab43
to
db9da4f
Compare
scarf005
force-pushed
the
drag-heavy-vehicle
branch
from
May 19, 2023 02:05
db9da4f
to
72529de
Compare
Nice, that was the number one aspect I would've been inclined to grab. |
scarf005
requested review from
Firestorm01X2 and
chaosvolt
and removed request for
Firestorm01X2
May 20, 2023 05:04
chaosvolt
approved these changes
May 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Compiled and load-tested.
- Spawned in a car, can push it around with 8 strength but sometimes takes time or strains.
- Took parts off until weight was under 800 kg, it moves without straining, only sometimes taking extra time.
- Increased strength to 9, no more "takes time" messages showed up.
- Summoned a semi truck, can't even try to shove it at 9 strength.
- Increased strength to 70, can indeed move it.
Side note, vehicle pushing is just amazingly janky when you're trying to turn it around, but this is unrelated to the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "player can drag heavier vehicles"
Purpose of change
port CleverRaven/Cataclysm-DDA#64867 by @anoobindisguise
Describe the solution
grabbed_veh_move
.Testing
2023-05-19.09-35-20.mp4