Switch a time type to fs:: #64314
Merged
Switch a time type to fs:: #64314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using std::filesystem::file_time_type when we should have been using fs::file_time_type. These types are the same on some platforms, but not on others.
github-actions
bot
added
[C++]
|
The reason why it compiled on CI but failed on release build is because the target macOS version in CI build is 10.15 but it's 10.12 in release build.
|
github-actions
bot
added
the
BasicBuildPassed
jbytheway
added a commit
to jbytheway/Cataclysm-DDA
that referenced
this pull request
Mar 18, 2023
To avoid bugs appearing in release builds that were not detected on CI, update the CI build script to use the same OSX_MIN value as release builds. See for example CleverRaven#64314 which was such an issue.
kevingranade
pushed a commit
that referenced
this pull request
Mar 19, 2023
To avoid bugs appearing in release builds that were not detected on CI, update the CI build script to use the same OSX_MIN value as release builds. See for example #64314 which was such an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
There were build errors on the OS X build. See for example this one. They seemed to only appear on the release build, not the PR CI build.
We were using
std::filesystem::file_time_typewhen we should have been usingfs::file_time_type. These types are the same on some platforms, but not on others.Describe the solution
Switch to the correct type.
Describe alternatives you've considered
None.
Testing
I verified it still builds on Linux, but I can't test on OS X. I'm not sure even CI will test this properly. We might have to just merge and hope the release builds do better.
Additional context