Set OSX_MIN on CI to match release workflow #64364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid bugs appearing in release builds that were not detected on CI, update the CI build script to use the same OSX_MIN value as release builds. See for example CleverRaven#64314 which was such an issue.
github-actions
bot
added
Code: Build
|
I also see this cannot find passenger error in macOS and MinGW+wine tests in a few other pull requests, but I failed to reproduce the error locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Set OSX_MIN on CI to match release workflow"
Purpose of change
To avoid bugs appearing in release builds that were not detected on CI.
See for example #64314 which was such an issue.
Describe the solution
Update the CI build script to use the same OSX_MIN value as release builds.
Describe alternatives you've considered
This is my best guess as to the source of the discrepancy; they both build on version 10.15 build hosts.
Testing
Will need to be tested on CI.
Additional context