Skip to content

Commit

Permalink
Set OSX_MIN on CI to match release workflow
Browse files Browse the repository at this point in the history
To avoid bugs appearing in release builds that were not detected on CI,
update the CI build script to use the same OSX_MIN value as release
builds.

See for example CleverRaven#64314 which was such an issue.
  • Loading branch information
jbytheway committed Mar 18, 2023
1 parent a577338 commit 8ae20e3
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion build-scripts/gha_compile_only.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ then
..
make -j$num_jobs
else
make -j "$num_jobs" RELEASE=1 CCACHE=1 CROSS="$CROSS_COMPILATION" LINTJSON=0
# The OSX_MIN version here should match that used in release builds so that
# CI detects issues that will affect releases. It doesn't affect builds on
# other platforms.
make -j "$num_jobs" RELEASE=1 CCACHE=1 CROSS="$CROSS_COMPILATION" LINTJSON=0 OSX_MIN=10.12
fi

# vim:tw=0

0 comments on commit 8ae20e3

Please sign in to comment.