-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wax changes #62843
Wax changes #62843
Conversation
Fixed issues and am running this for merging rn, However in the future it might be worth it to move the waxes into a crafting group so they don't need to be duplicated everywhere they are used interchangably. |
That is a very fair point. I did this manually because, like mentioned in the description, I have no idea how often these waxes can be used interchangeably. I know in cooking they wouldn't be but we don't use wax anywhere in cooking yet. |
Yeah, I don't think they exclusively should be grouped, but having it as an option in the future might be nice. If you want to do it for this PR that's fine too but no pressure it was a future suggestion :) |
Yeah give me a moment I'll get it done, that's like 10 minutes of work |
dba8df1
to
09589c6
Compare
This commit history is fantastic. Keep at it. I added the wax to toilets and it always bothered be that you could eat it lol. |
I think you also need to copy books where this recipes can be found? |
You're right. I hate |
* first waxing * the incredible wax * cleanup * cleanup * itemgroups * linting linting * linting more linting I love linting * density fixed hallelujah * crafting requirements * I hate syntax I hate syntax I hate syntax * please work * Update lights.json * I'm going insane here * please tell me it's over * stop stop stop * are we done yet? * material resistances * raise the white flag * bookz --------- Co-authored-by: bombasticSlacks <[email protected]>
* first waxing * the incredible wax * cleanup * cleanup * itemgroups * linting linting * linting more linting I love linting * density fixed hallelujah * crafting requirements * I hate syntax I hate syntax I hate syntax * please work * Update lights.json * I'm going insane here * please tell me it's over * stop stop stop * are we done yet? * material resistances * raise the white flag * bookz --------- Co-authored-by: bombasticSlacks <[email protected]>
Summary
Balance "Plenty of changes regarding wax and the addition of paraffin wax"
Purpose of change
I was incredibly annoyed that I could eat the wax rings around toilets.
Describe the solution
Beeswax changes
New material: Paraffin Wax
Candle changes
Describe alternatives you've considered
I really really wanted to have candles be cuttable the same way plastic or cotton is so that you could salvage paraffin wax chunks from them but the code stumped me. I am almost certain I made the wax materials able to be cut yet during my testing I could not for the love of me get candles to be cuttable. I am not sure what I did wrong and I'd appreciate feedback on this.
Testing
The recipes and items appear to work just about fine. The only issue I've come across was when I tried making candles cuttable - still can't get that to work.
Additional context
Requires #63931 to be fixed before being able to get green test results