-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy-from
cannot properly carry over (or overwrite?) LIST requirements listed in components
field
#63931
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
copy_from
in specific armor recipescopy-from
in specific armor recipes
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
/confirm Just a thought but it might help debugging if there was a minimal test mod with save included that reproduces this on loading. That is, if these emerge in game and not just in test runs |
copy-from
in specific armor recipescopy-from
cannot properly carry over (or overwrite?) LIST requirements listed in components
field
I opted to update this issue with the newfound knowledge I obtained while working on the wax PR. I think in this state the problem at hand is at least visible, and maybe it gets fixed at some point. I do admit the first iteration of this issue was less than helpful. |
Describe the bug
#62843 is having peculiar test failures related to crafting requirement groups in specific recipes. On the devcord, it was brought up that these specific armors have had this problem before already and it is assumed to be caused byI am now smarter and can see things as they truly are. I knowcopy_from
integration between them. I was advised to report this.copy-from
is evil. So I can now fully say that this is an issue withcopy-from
and requirement groups using "LIST" under thecomponents
field of the recipe. I am not sure whether the problem is that these requirements cannot be overwritten, or because they just do not want to carry over, but I know they're at fault.Attach save file
N/A, but my hubris is recorded in the commit history of #62843
Steps to reproduce
copy-from
from a recipe which already has "LIST" requirement groups under component field (such asarmor_blarmor
)components
field of the new recipe, add the same requirement group that the copied recipe usesExpected behavior
Errors bad :(
Screenshots
No response
Versions and configuration
N/A
Additional context
No response
The text was updated successfully, but these errors were encountered: