Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candlestick can indeed stick to the candle again #69913

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Dec 2, 2023

Summary

None

Purpose of change

Some moron in #62843 increased the size of a candle but didn't adjust the candlestick so now I am paying for my hubris

Describe the solution

  • Adjust the candlestick pocket volume to go in hand with the increased volume of a candle
  • Give candlestick transparent: true. I am like 99% sure this actually doesn't do shit right now but I'm doing it in preparation for Only transparent pockets allow light to pass through them #67595 while I'm here
  • Shortened the amazon link in the comment because it looked ugly

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 2, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 2, 2023
@Maleclypse Maleclypse merged commit e3831a5 into CleverRaven:master Dec 2, 2023
24 checks passed
@Karol1223 Karol1223 deleted the evil branch December 2, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants