Update Aftershock dead survivor loot item group

[BrettDong]

Summary

None

Purpose of change

• Fix afs_corpse_old fails on item group test #62220

#61575 forbids corpses containing items. This change breaks an item group defined in the Aftershock mod. This is causing errors in basic build test in almost all recent pull requests.

Describe the solution

Update the broken item group to spawn the corpse alongside with the loot items.

Describe alternatives you've considered

Testing

./tests/cata_test --mods=dda,aftershock "~*" no longer errors.

Additional context

[Fris0uman]

It should spawn correctly in game though, this 393f630 fixed the error when loading the game at least. Maybe we need to do somethign similar for the test run?

[BrettDong]

Item group consistency check also calls put_into_container() to put loot items in the corpse. If it works fine in game then the test should also pass.

[Fris0uman]

So you mean it doesn't actually work in game?

[BrettDong]

Yes, the error also appears when I try to create a character in a world with Aftershock mod:

[mqrause]

I'm not 100% sure how these item groups with corpses work. But as far as I understand they're supposed to create corpses that "wear" stuff with the worn stuff containing other items spawned in the group. Not sure if this fix will still produce that result or if it will spawn a corpse next to some other items. If it's the latter, then the real issue is more like #59873: some item group doesn't have appropriate container items to contain all the additional things it spawns.

[Fris0uman]

Okay so I don't know where I messed up my test. Still I think it would be better to find a c++ fix so that the items are still put into corpses as if they were wearing it rather than droping it next to them. Plus in vanilla the mapgened corpse can revive and they'll keep their loot if they have it inside the pocket

[mqrause]

Looking into it a bit more, the issue seems to be even still different:

Cataclysm-DDA/src/item_group.cpp

Lines 126 to 128 in d1f765d

	if( ctr.can_contain( *it ).success() ) {
	const item_pocket::pocket_type pk_type = guess_pocket_for( ctr, *it );
	ctr.put_in( *it, pk_type );

item::can_contain will also check all nested pockets of the container, however item::put_in can only put things directly in the container. That's why it sometimes tries to insert things into a corpse the normal way instead of forcing it in or putting it into an appropriate container. So that needs to be sorted out one way or the other.