-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No more corpse of holding #61575
Merged
Merged
No more corpse of holding #61575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Changes (can be) made in C++. Previously named `Code`
Items: Containers
Things that hold other things
<Bugfix>
This is a fix for a bug (or closes open issue)
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[JSON]
Changes (can be) made in JSON
<Documentation>
Design documents, internal info, guides and help.
[Markdown]
Markdown issues and PRs
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Oct 9, 2022
Fris0uman
requested review from
Maleclypse,
John-Candlebury and
Mom-Bun
as code owners
October 11, 2022 16:24
github-actions
bot
added
Mods
Issues related to mods or modding
Mods: Aftershock
Anything to do with the Aftershock mod
Spawn
Creatures, items, vehicles, locations appearing on map
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Oct 11, 2022
Fris0uman
removed
Mods
Issues related to mods or modding
Mods: Aftershock
Anything to do with the Aftershock mod
labels
Oct 12, 2022
Fris0uman
force-pushed
the
squirel_final_rest
branch
from
October 22, 2022 09:15
5e76d8a
to
393f630
Compare
github-actions
bot
added
BasicBuildPassed
This PR builds correctly, label assigned by github actions
and removed
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
[C++]
Changes (can be) made in C++. Previously named `Code`
<Documentation>
Design documents, internal info, guides and help.
Items: Containers
Things that hold other things
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Corpses can't be used as bag of holding anymore"
Purpose of change
Describe the solution
- [ ] Fixallowed
not being saved or loaded(?) properlyallowed
topocket_data
so we don't need to save and load it and rename itforbidden
is_corpse
andis_forbidden
to not display pocket info when not necessaryis_forbidden
to make sure we can't stuff in there when grabbing items of the groundDescribe alternatives you've considered
Since we're using
force_insert_item
to put the loot into corpses, we could make that pocket be 0 ml and 0 g and get rid of the rest of the implementation, no need for aallowed
variable in that case or for extra checks. But 0 volume and 0 weight pocket do generate a bunch of error on loadTesting
g
picksu menu or in AIM menuAdditional context