Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

professional_zombie_gear item group can cause errors on monster death #59873

Closed
mqrause opened this issue Aug 3, 2022 · 2 comments
Closed

professional_zombie_gear item group can cause errors on monster death #59873

mqrause opened this issue Aug 3, 2022 · 2 comments
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@mqrause
Copy link
Contributor

mqrause commented Aug 3, 2022

Describe the bug

It is possible a monster death can create an error message leading to CI test fails.
https://github.com/CleverRaven/Cataclysm-DDA/runs/7653184359?check_suite_focus=true#step:16:430

Steps to reproduce

I have not been able to reproduce the issue with the seed from the failed test and in another 60 random test runs locally.

However digging into the test code I can fairly safely conclude the cause is the chance for professional_zombie_gear in the default_zombie_death_drops item group.
professional_zombie_gear contains the group hardware_plumbing, which in turn contains plumbing_clothing which has the explicit comment "//2": "Not intended to be a set of clothing for NPCs or monsters", most likely because it does not guarantee in any way that proper container items are spawned for any additional loot to be put in, since it seems to only spawn one item from the list and not a set of gear the zombie would be wearing.

Expected behavior

Items spawn without issues. However in this case it might be unlikely enough to not be a problem.

Screenshots

No response

Versions and configuration

bc8d87c

Additional context

No response

@mqrause mqrause added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Aug 3, 2022
@Stadler76
Copy link
Contributor

@mqrause
Copy link
Contributor Author

mqrause commented Aug 17, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

2 participants