Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build test failing #61378

Closed
anoobindisguise opened this issue Oct 1, 2022 · 5 comments
Closed

Windows build test failing #61378

anoobindisguise opened this issue Oct 1, 2022 · 5 comments
Labels
Code: Tests Measurement, self-control, statistics, balancing. Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@anoobindisguise
Copy link
Contributor

Describe the bug

20:51:10.318 ERROR : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\item.cpp:1501 [put_in] tried to put an item (creepy_doll) count (1) in a container (purse) that cannot contain it: pocket unacceptable because not enough space
@Maleclypse wanted me to open an issue for this. I've seen a similar error to this quite a few times in previous PRs.

Steps to reproduce

?? It seems to happen at random and I have no idea how the test works

Expected behavior

The test should pass, but I don't know what's causing it to fail and as a result, what needs to change.

Screenshots

No response

Versions and configuration

current

Additional context

No response

@anoobindisguise anoobindisguise added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Oct 1, 2022
@mqrause
Copy link
Contributor

mqrause commented Oct 1, 2022

Maybe also #59873, or a similar issue with another item group. A link to a test failure would be nice to get some context.

@anoobindisguise
Copy link
Contributor Author

Maybe also #59873, or a similar issue with another item group. A link to a test failure would be nice to get some context.

Unfortunately the PR that prompted this issue to be submitted already had that test bumped so it's no longer visible there. (#61328)

@mqrause
Copy link
Contributor

mqrause commented Oct 1, 2022

For these somewhat random errors in non-required tests, it's better to just leave them as is so people can check where they actually happened.

@BrettDong
Copy link
Member

The cause does not seem to be related to the Windows platform, so I'd suggest you to remove "Windows" from the title.

@BrettDong BrettDong added Code: Tests Measurement, self-control, statistics, balancing. Items: Containers Things that hold other things and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Oct 1, 2022
@stale
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Nov 2, 2022
@Maleclypse Maleclypse added the (S2 - Confirmed) Bug that's been confirmed to exist label Nov 3, 2022
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code: Tests Measurement, self-control, statistics, balancing. Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

No branches or pull requests

4 participants